From 103dc42b5ec134362db9b6dfb32edf10344e6769 Mon Sep 17 00:00:00 2001 From: Will Thompson Date: Tue, 7 Aug 2018 14:16:46 +0000 Subject: [PATCH] doc: fix typos in CONTRIBUTING.md * Cover letters are no more; presumably the changes since the previous revision should be summarised in the MR * Code should be indented with tabs, not implemented with tabs Signed-off-by: Will Thompson --- CONTRIBUTING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f2e4750d..7e22afab 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -85,7 +85,7 @@ We won't reject patches that lack S-o-b, but it is strongly recommended. When you re-send patches, revised or not, it would be very good to document the changes compared to the previous revision in the commit message and/or the -cover letter. If you have already received Reviewed-by or Acked-by tags, you +merge request. If you have already received Reviewed-by or Acked-by tags, you should evaluate whether they still apply and include them in the respective commit messages. Otherwise the tags may be lost, reviewers miss the credit they deserve, and the patches may cause redundant review effort. @@ -134,7 +134,7 @@ You should follow the style of the file you're editing. In general, we try to follow the rules below. **Note: this file uses spaces due to markdown rendering issues for tabs. - Code must be implemented using tabs.** + Code must be indented using tabs.** - indent with tabs, and a tab is always 8 characters wide - opening braces are on the same line as the if statement;