libweston-desktop/xwayland: Do not over-destroy the view

With this weston_view_destroy() call, Xwayland popups make Weston freeze
in a busy-loop (probably corrupted wl_list).

Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>
dev
Quentin Glidic 8 years ago
parent 5c611d933f
commit 1714f01e0c
No known key found for this signature in database
GPG Key ID: AC203F96E2C34BB7
  1. 6
      libweston-desktop/xwayland.c

@ -152,13 +152,11 @@ weston_desktop_xwayland_surface_destroy(struct weston_desktop_surface *dsurface,
wl_list_remove(&surface->resource_destroy_listener.link); wl_list_remove(&surface->resource_destroy_listener.link);
weston_desktop_surface_unset_relative_to(surface->surface); weston_desktop_surface_unset_relative_to(surface->surface);
if (surface->added) { if (surface->added)
weston_desktop_api_surface_removed(surface->desktop, weston_desktop_api_surface_removed(surface->desktop,
surface->surface); surface->surface);
} else if (surface->state == XWAYLAND) { else if (surface->state == XWAYLAND)
weston_desktop_surface_unlink_view(surface->view); weston_desktop_surface_unlink_view(surface->view);
weston_view_destroy(surface->view);
}
free(surface); free(surface);
} }

Loading…
Cancel
Save