From 214d48bbabc6f55cf3a9d251256be6d818d9d6df Mon Sep 17 00:00:00 2001 From: Derek Foreman Date: Thu, 28 Jul 2022 08:12:21 -0500 Subject: [PATCH] compositor: Fix use after free at shutdown Another case of forgetting to remove a listener from a list when signal_emit_mutable fires. Signed-off-by: Derek Foreman --- compositor/xwayland.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/compositor/xwayland.c b/compositor/xwayland.c index cf84c882..b25b74c9 100644 --- a/compositor/xwayland.c +++ b/compositor/xwayland.c @@ -234,6 +234,8 @@ wxw_compositor_destroy(struct wl_listener *listener, void *data) struct wet_xwayland *wxw = wl_container_of(listener, wxw, compositor_destroy_listener); + wl_list_remove(&wxw->compositor_destroy_listener.link); + /* Don't call xserver_exited because Xwayland's own destroy handler * already does this for us ... */ if (wxw->client)