From 23d330ec9d08864720766513c0414239e05f8d98 Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Thu, 10 Jan 2013 19:48:56 +0000 Subject: [PATCH] backlight: Avoid passing an invalid fd into close() --- src/libbacklight.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/libbacklight.c b/src/libbacklight.c index add89b27..98a20beb 100644 --- a/src/libbacklight.c +++ b/src/libbacklight.c @@ -68,7 +68,8 @@ static long backlight_get(struct backlight *backlight, char *node) value = strtol(buffer, NULL, 10); ret = value; out: - close(fd); + if (fd >= 0) + close(fd); free(path); return ret; } @@ -124,10 +125,10 @@ long backlight_set_brightness(struct backlight *backlight, long brightness) ret = backlight_get_brightness(backlight); backlight->brightness = ret; out: - if (buffer) - free(buffer); + free(buffer); free(path); - close(fd); + if (fd >= 0) + close(fd); return ret; }