From 3abdafd12d67c2effa239c8e30415c24c162ec12 Mon Sep 17 00:00:00 2001 From: "Bryce W. Harrington" Date: Tue, 14 Jan 2014 21:58:32 +0000 Subject: [PATCH] terminal: Only set title if asprintf succeeded MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Handles potential out of memory situation by skipping the title update. This fixes the following warning: terminal.c: In function ‘resize_handler’: terminal.c:851:11: warning: ignoring return value of ‘asprintf’, declared with attribute warn_unused_result [-Wunused-result] Signed-off-by: Bryce Harrington --- clients/terminal.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/clients/terminal.c b/clients/terminal.c index e2a6236c..09bc3215 100644 --- a/clients/terminal.c +++ b/clients/terminal.c @@ -848,9 +848,10 @@ resize_handler(struct widget *widget, width = columns * terminal->average_width + m; height = rows * terminal->extents.height + m; widget_set_size(terminal->widget, width, height); - asprintf(&p, "%s — [%dx%d]", terminal->title, columns, rows); - window_set_title(terminal->window, p); - free(p); + if (asprintf(&p, "%s — [%dx%d]", terminal->title, columns, rows) > 0) { + window_set_title(terminal->window, p); + free(p); + } } terminal_resize_cells(terminal, columns, rows);