mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compositor-drm: drm_property_info_free() must reset

Browse Source 
This function needs to reset the structures to NULL, otherwise it is not
possible to re-use a once "freed" property info array.

Being able to re-use an array is useful when the memory allocation and
array lifetimes do not match. A specific example is drm_output that is
changed to allocate the CRTC on enable() and deallocate it on disable().
A drm_output might be enabled and disabled multiple times.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Ian Ray <ian.ray@ge.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Pekka Paalanen
2017-09-07 15:32:01 +03:00
parent 383b3af5e1
commit 46e4f97ab6
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libweston/compositor-drm.c
+5 -1
View File
@@ -721,7 +721,9 @@ drm_property_info_populate(struct drm_backend *b,
/** /**
* Free DRM property information * Free DRM property information
* *
* Frees all memory associated with a DRM property info array. * Frees all memory associated with a DRM property info array and zeroes
* it out, leaving it usable for a further drm_property_info_update() or
* drm_property_info_free().
* *
* @param info DRM property info array * @param info DRM property info array
* @param num_props Number of entries in array to free * @param num_props Number of entries in array to free
@@ -733,6 +735,8 @@ drm_property_info_free(struct drm_property_info *info, int num_props)
for (i = 0; i < num_props; i++) for (i = 0; i < num_props; i++)
free(info[i].enum_values); free(info[i].enum_values);
memset(info, 0, sizeof(*info) * num_props);
} }
static void static void