From 4e907a67e5537e502e9666e52e6897c2623f2291 Mon Sep 17 00:00:00 2001
From: Hideyuki Nagase <hideyukn@microsoft.com>
Date: Tue, 22 Mar 2022 11:13:46 -0500
Subject: [PATCH] rdp: Add high precision scrolling

Co-authored-by: Steve Pronovost <spronovo@microsoft.com>
Co-authored-by: Brenton DeGeer <brdegeer@microsoft.com>
Signed-off-by: Hideyuki Nagase <hideyukn@microsoft.com>
Signed-off-by: Steve Pronovost <spronovo@microsoft.com>
Signed-off-by: Brenton DeGeer <brdegeer@microsoft.com>
---
 libweston/backend-rdp/rdp.c | 76 ++++++++++++++++++++++++++++---------
 libweston/backend-rdp/rdp.h |  3 ++
 2 files changed, 61 insertions(+), 18 deletions(-)

diff --git a/libweston/backend-rdp/rdp.c b/libweston/backend-rdp/rdp.c
index c7690459..ad411926 100644
--- a/libweston/backend-rdp/rdp.c
+++ b/libweston/backend-rdp/rdp.c
@@ -1025,31 +1025,71 @@ ignore:
 	*button = 0;
 }
 
-static void
+static bool
 rdp_notify_wheel_scroll(RdpPeerContext *peerContext, UINT16 flags)
 {
 	struct weston_pointer_axis_event weston_event;
+	struct rdp_backend *b = peerContext->rdpBackend;
+	int ivalue;
 	double value;
 	struct timespec time;
-
-	/* DEFAULT_AXIS_STEP_DISTANCE is stolen from compositor-x11.c
-	 * The RDP specs says the lower bits of flags contains the "the number of rotation
-	 * units the mouse wheel was rotated".
-	 *
-	 * https://devblogs.microsoft.com/oldnewthing/20130123-00/?p=5473 explains the 120 value
-	 */
-	value = -(flags & 0xff) / 120.0;
+	int *accumWheelRotationPrecise;
+	int *accumWheelRotationDiscrete;
+
+	/*
+	* The RDP specs says the lower bits of flags contains the "the number of rotation
+	* units the mouse wheel was rotated".
+	*/
+	ivalue = ((int)flags & 0x000000ff);
 	if (flags & PTR_FLAGS_WHEEL_NEGATIVE)
-		value = -value;
+		ivalue = (0xff - ivalue) * -1;
+
+	/*
+	* Flip the scroll direction as the RDP direction is inverse of X/Wayland
+	* for vertical scroll
+	*/
+	ivalue *= -1;
+
+	accumWheelRotationPrecise = &peerContext->verticalAccumWheelRotationPrecise;
+	accumWheelRotationDiscrete = &peerContext->verticalAccumWheelRotationDiscrete;
+
+	/*
+	* Accumulate the wheel increments.
+	*
+	* Every 12 wheel increments, we will send an update to our Wayland
+	* clients with an updated value for the wheel for smooth scrolling.
+	*
+	* Every 120 wheel increments, we tick one discrete wheel click.
+	*
+	* https://devblogs.microsoft.com/oldnewthing/20130123-00/?p=5473 explains the 120 value
+	*/
+	*accumWheelRotationPrecise += ivalue;
+	*accumWheelRotationDiscrete += ivalue;
+	rdp_debug_verbose(b, "wheel: rawValue:%d accumPrecise:%d accumDiscrete %d\n",
+			  ivalue, *accumWheelRotationPrecise, *accumWheelRotationDiscrete);
+
+	if (abs(*accumWheelRotationPrecise) >= 12) {
+		value = (double)(*accumWheelRotationPrecise / 12);
+
+		weston_event.axis = WL_POINTER_AXIS_VERTICAL_SCROLL;
+		weston_event.value = value;
+		weston_event.discrete = *accumWheelRotationDiscrete / 120;
+		weston_event.has_discrete = true;
+
+		rdp_debug_verbose(b, "wheel: value:%f discrete:%d\n",
+				  weston_event.value, weston_event.discrete);
+
+		weston_compositor_get_time(&time);
+
+		notify_axis(peerContext->item.seat, &time, &weston_event);
 
-	weston_event.axis = WL_POINTER_AXIS_VERTICAL_SCROLL;
-	weston_event.value = DEFAULT_AXIS_STEP_DISTANCE * value;
-	weston_event.discrete = (int)value;
-	weston_event.has_discrete = true;
+		*accumWheelRotationPrecise %= 12;
+		*accumWheelRotationDiscrete %= 120;
 
-	weston_compositor_get_time(&time);
+		return true;
+	}
 
-	notify_axis(peerContext->item.seat, &time, &weston_event);
+	return false;
 }
 
 static BOOL
@@ -1095,8 +1135,8 @@ xf_mouseEvent(rdpInput *input, UINT16 flags, UINT16 x, UINT16 y)
 	}
 
 	if (flags & PTR_FLAGS_WHEEL) {
-		rdp_notify_wheel_scroll(peerContext, flags);
-		need_frame = true;
+		if (rdp_notify_wheel_scroll(peerContext, flags))
+			need_frame = true;
 	}
 
 	if (need_frame)
diff --git a/libweston/backend-rdp/rdp.h b/libweston/backend-rdp/rdp.h
index 9b32ab4c..1d0228bc 100644
--- a/libweston/backend-rdp/rdp.h
+++ b/libweston/backend-rdp/rdp.h
@@ -112,6 +112,9 @@ struct rdp_peer_context {
 	struct rdp_peers_item item;
 
 	bool button_state[5];
+
+	int verticalAccumWheelRotationPrecise;
+	int verticalAccumWheelRotationDiscrete;
 };
 typedef struct rdp_peer_context RdpPeerContext;