mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wcap: Prevent fd leak in wcap_decoder_create() fail path

Browse Source 
Signed-off-by: Sergi Granell <xerpi.g.12@gmail.com>
Reviewed-by: Quentin Glidic <sardemff7+git@sardemff7.net>
This commit is contained in:
Sergi Granell
2017-03-29 22:41:02 +02:00
committed by Quentin Glidic
parent fec723ef56
commit 597dde5cf6
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wcap/wcap-decode.c
+2
View File
@@ -131,6 +131,7 @@ wcap_decoder_create(const char *filename)
PROT_READ, MAP_PRIVATE, decoder->fd, 0); PROT_READ, MAP_PRIVATE, decoder->fd, 0);
if (decoder->map == MAP_FAILED) { if (decoder->map == MAP_FAILED) {
fprintf(stderr, "mmap failed\n"); fprintf(stderr, "mmap failed\n");
close(decoder->fd);
free(decoder); free(decoder);
return NULL; return NULL;
} }
@@ -146,6 +147,7 @@ wcap_decoder_create(const char *filename)
frame_size = header->width * header->height * 4; frame_size = header->width * header->height * 4;
decoder->frame = malloc(frame_size); decoder->frame = malloc(frame_size);
if (decoder->frame == NULL) { if (decoder->frame == NULL) {
close(decoder->fd);
free(decoder); free(decoder);
return NULL; return NULL;
} }