Use weston_compositor_add_destroy_listener_once() in plugins
This introduces a new convention of checking through the compositor destroy listener if the plugin is already initialized. If the plugin is already initialized, then the plugin entry function succeeds as a no-op. This makes it safe to load the same plugin multiple times in a running compositor. Currently module loading functions return failure if a plugin is already loaded, but that will change in the future. Therefore we need this other method of ensuring we do not double-initialize a plugin which would lead to list corruptions the very least. All plugins are converted to use the new helper, except: - those that do not have a destroy listener already, and - hmi-controller which does the same open-coded as the common code pattern did not fit there. Plugins should always have a compositor destroy listener registered since they very least allocate a struct to hold their data. Hence omissions are highlighted in code. Backends do not need this because weston_compositor_load_backend() already protects against double-init. GL-renderer does not export a standard module init function so cannot be initialized the usual way and therefore is not vulnerable to double-init. Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>
This commit is contained in:
committed by
Daniel Stone
parent
5caef6d355
commit
6ffbba3ac1
@@ -1773,6 +1773,11 @@ struct weston_compositor *
|
||||
weston_compositor_create(struct wl_display *display,
|
||||
struct weston_log_context *log_ctx, void *user_data);
|
||||
|
||||
bool
|
||||
weston_compositor_add_destroy_listener_once(struct weston_compositor *compositor,
|
||||
struct wl_listener *listener,
|
||||
wl_notify_func_t destroy_handler);
|
||||
|
||||
enum weston_compositor_backend {
|
||||
WESTON_BACKEND_DRM,
|
||||
WESTON_BACKEND_FBDEV,
|
||||
|
||||
Reference in New Issue
Block a user