From 90f23ca3f46f8721496ee5d7b73c24a2f17dd4f5 Mon Sep 17 00:00:00 2001 From: "Jon A. Cruz" Date: Thu, 9 Apr 2015 17:52:56 -0700 Subject: [PATCH] build: give explicit error when unable to setuid on install. Added build error message when 'make install' is run as non-root and the --disable-setuid-install configuration option has not been used. Signed-off-by: Jon A. Cruz Acked-by: Peter Hutterer Tested-by: Pekka Paalanen --- Makefile.am | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4aa41ffb..c1347b86 100644 --- a/Makefile.am +++ b/Makefile.am @@ -161,8 +161,15 @@ weston_launch_LDADD = $(PAM_LIBS) $(SYSTEMD_LOGIN_LIBS) $(LIBDRM_LIBS) if ENABLE_SETUID_INSTALL install-exec-hook: - chown root $(DESTDIR)$(bindir)/weston-launch - chmod u+s $(DESTDIR)$(bindir)/weston-launch + can_suid_files=no; \ + chown root $(DESTDIR)$(bindir)/weston-launch \ + && chmod u+s $(DESTDIR)$(bindir)/weston-launch \ + && can_suid_files=yes;\ + if test $$can_suid_files=no; then \ + echo 'Error: unable to unable to change ownership/setuid on weston-launch.'; \ + echo 'To skip this step, re-run ./configure using --disable-setuid-install'; \ + false; \ + fi endif endif # BUILD_WESTON_LAUNCH