mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ivi-layout: abort without controller_module_init

Browse Source 
When loading a controller module, if we do not find a
controller_module_init symbol, return failure to the caller instead of
ignoring the failure.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Tested-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA@xddp.denso.co.jp>
This commit is contained in:
Pekka Paalanen
2015-03-26 15:47:29 +02:00
parent 8a005252d1
commit 97246c067d
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ivi-shell/ivi-layout.c
+8 -6
View File
@@ -2953,12 +2953,14 @@ load_controller_modules(struct weston_compositor *compositor, const char *module
snprintf(buffer, sizeof buffer, "%.*s", (int)(end - p), p); snprintf(buffer, sizeof buffer, "%.*s", (int)(end - p), p);
controller_module_init = weston_load_module(buffer, "controller_module_init"); controller_module_init = weston_load_module(buffer, "controller_module_init");
if (controller_module_init) if (!controller_module_init)
if(controller_module_init(compositor, argc, argv, return -1;
&ivi_controller_interface,
sizeof(struct ivi_controller_interface)) != 0) { if (controller_module_init(compositor, argc, argv,
weston_log("ivi-shell: Initialization of controller module fails"); &ivi_controller_interface,
return -1; sizeof(struct ivi_controller_interface)) != 0) {
weston_log("ivi-shell: Initialization of controller module fails");
return -1;
} }
p = end; p = end;