mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Get rid of the window_create_menu function

Browse Source 
It's currently unused, and there's actually no way to use it correctly.

The caller cannot free the menu that was created:
- the function only returns the window, not the menu
- there's no public API to destroy a menu object

Signed-off-by: Dima Ryazanov <dima@gmail.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
This commit is contained in:
Dima Ryazanov
2016-11-13 23:44:52 -08:00
committed by Daniel Stone
parent c0271533d0
commit 9b1f8ef7bc
2 changed files with 0 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/window.c
-15
View File
@@ -5470,21 +5470,6 @@ create_menu(struct display *display,
return menu; return menu;
} }
struct window *
window_create_menu(struct display *display,
struct input *input, uint32_t time,
menu_func_t func, const char **entries, int count,
void *user_data)
{
struct menu *menu;
menu = create_menu(display, input, time, func, entries, count, user_data);
if (menu == NULL)
return NULL;
return menu->window;
}
static struct zxdg_positioner_v6 * static struct zxdg_positioner_v6 *
create_simple_positioner(struct display *display, create_simple_positioner(struct display *display,
int x, int y, int w, int h) int x, int y, int w, int h)
clients/window.h
-5
View File
@@ -322,11 +322,6 @@ window_has_focus(struct window *window);
typedef void (*menu_func_t)(void *data, struct input *input, int index); typedef void (*menu_func_t)(void *data, struct input *input, int index);
struct window *
window_create_menu(struct display *display,
struct input *input, uint32_t time,
menu_func_t func, const char **entries, int count,
void *user_data);
void void
window_show_menu(struct display *display, window_show_menu(struct display *display,
struct input *input, uint32_t time, struct window *parent, struct input *input, uint32_t time, struct window *parent,