In the original conception, a weston_buffer_reference indicated that the underlying contents of the wl_buffer would or could be accessed, so wl_buffer.release must not be sent until the last reference was released, as the compositor may still use it. This meant that renderers or backends which copied the buffer content - such as the GL renderer with SHM buffers - could only send a buffer release event to the client by 'losing' the buffer reference altogether. The main side effect is that `weston-debug scene-graph` could not show any information at all about SHM buffers when using the GL renderer, but it also meant that renderers and backends grew increasingly exotic structures to cache information about the buffer. Now that we have an additional buffer-reference mode (still referring to the weston_buffer/wl_buffer, but not going to access its content), we can allow the weston_buffer_reference and weston_buffer to live as long as the buffer itself, even if we do send a release event. This will enable a bunch of backend and renderer deduplication, as well as finally making scene-graph more useful. Signed-off-by: Daniel Stone <daniels@collabora.com>dev
parent
fdc7b9c352
commit
a42908204f
Loading…
Reference in new issue