mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

backend-drm: document that we allow to import wl_drm buffers to KMS with no modifiers

Browse Source 
In commit "backend-drm: do not import dmabuf buffers with no modifiers
to KMS" we've stopped to import dmabuf with no modifiers to KMS.

In this patch we document why we can still import wl_drm buffers with no
modifiers to KMS.

Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com>
This commit is contained in:
Leandro Ribeiro
2021-04-26 08:47:45 -03:00
committed by Daniel Stone
parent 5aea1bc522
commit a5560d6dbe
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libweston/backend-drm/state-propose.c
+8
View File
@@ -138,8 +138,16 @@ drm_output_plane_has_valid_format(struct drm_plane *plane,
fmt = weston_drm_format_array_find_format(&plane->formats, fmt = weston_drm_format_array_find_format(&plane->formats,
fb->format->format); fb->format->format);
if (fmt) { if (fmt) {
/* We never try to promote a dmabuf with DRM_FORMAT_MOD_INVALID
* to a KMS plane (see drm_fb_get_from_dmabuf() for more details).
* So if fb->modifier == DRM_FORMAT_MOD_INVALID, we are sure
* that this is for the legacy GBM import path, in which a
* wl_drm is being used for scanout. Mesa is the only user we
* care in this case (even though recent versions are also using
* dmabufs), and it should know better what works or not. */
if (fb->modifier == DRM_FORMAT_MOD_INVALID) if (fb->modifier == DRM_FORMAT_MOD_INVALID)
return true; return true;
if (weston_drm_format_has_modifier(fmt, fb->modifier)) if (weston_drm_format_has_modifier(fmt, fb->modifier))
return true; return true;
} }