From b878357dfdca5003bb4bf451dcf4a2b9c0bc1084 Mon Sep 17 00:00:00 2001 From: Pekka Paalanen Date: Wed, 8 Jun 2022 14:14:12 +0300 Subject: [PATCH] tests: remove skip() as unused skip() is a left-over from an old test harness design, the comment even refers to automake. Calling skip() cannot do anything good anymore, because it wouldn't print the skips in the TAP report, so it would probably be considered a failure. Delete this unused and nowadays incorrect function, so it doesn't confuse people. Signed-off-by: Pekka Paalanen --- tests/weston-test-client-helper.c | 16 ---------------- tests/weston-test-client-helper.h | 3 --- 2 files changed, 19 deletions(-) diff --git a/tests/weston-test-client-helper.c b/tests/weston-test-client-helper.c index 01c4b804..1b96f8e6 100644 --- a/tests/weston-test-client-helper.c +++ b/tests/weston-test-client-helper.c @@ -870,22 +870,6 @@ static const struct wl_registry_listener registry_listener = { handle_global_remove, }; -void -skip(const char *fmt, ...) -{ - va_list argp; - - va_start(argp, fmt); - vfprintf(stderr, fmt, argp); - va_end(argp); - - /* automake tests uses exit code 77. weston-test-runner will see - * this and use it, and then weston-test's sigchld handler (in the - * weston process) will use that as an exit status, which is what - * ninja will see in the end. */ - exit(77); -} - void expect_protocol_error(struct client *client, const struct wl_interface *intf, diff --git a/tests/weston-test-client-helper.h b/tests/weston-test-client-helper.h index 8e1505d4..b30fdb7f 100644 --- a/tests/weston-test-client-helper.h +++ b/tests/weston-test-client-helper.h @@ -232,9 +232,6 @@ frame_callback_wait_nofail(struct client *client, int *done); #define frame_callback_wait(c, d) assert(frame_callback_wait_nofail((c), (d))) -void -skip(const char *fmt, ...); - void expect_protocol_error(struct client *client, const struct wl_interface *intf, uint32_t code);