From bbc749af73431435a8f16e054f8fa1f2c902383a Mon Sep 17 00:00:00 2001 From: Pekka Paalanen Date: Tue, 15 Nov 2016 12:22:09 +0200 Subject: [PATCH] libweston-desktop/xwayland: XWAYLAND surfaces are never 'added' Add documentation (asserts) that show that windows of types XWAYLAND are never registered with the shell. Signed-off-by: Pekka Paalanen Reviewed-by: Daniel Stone Reviewed-by: Quentin Glidic --- libweston-desktop/xwayland.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libweston-desktop/xwayland.c b/libweston-desktop/xwayland.c index f7c61e17..41bc4c89 100644 --- a/libweston-desktop/xwayland.c +++ b/libweston-desktop/xwayland.c @@ -83,6 +83,8 @@ weston_desktop_xwayland_surface_change_state(struct weston_desktop_xwayland_surf if (surface->state != state) { if (surface->state == XWAYLAND) { + assert(!surface->added); + weston_desktop_surface_unlink_view(surface->view); weston_view_destroy(surface->view); surface->view = NULL; @@ -100,6 +102,8 @@ weston_desktop_xwayland_surface_change_state(struct weston_desktop_xwayland_surf } if (state == XWAYLAND) { + assert(!surface->added); + surface->view = weston_desktop_surface_create_view(surface->surface); weston_layer_entry_insert(&surface->xwayland->layer.view_list,