mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tablet-shell: Avoid leaking the path on failed icon loading

Browse Source
This commit is contained in:
Rob Bradford
2013-07-26 16:29:42 +01:00
committed by Kristian Høgsberg
parent c9213e7353
commit c48c34d6fa
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/tablet-shell.c
+1 -1
View File
@@ -396,7 +396,6 @@ tablet_shell_add_launcher(struct tablet *tablet,
struct homescreen *homescreen = tablet->homescreen; struct homescreen *homescreen = tablet->homescreen;
launcher = malloc(sizeof *launcher); launcher = malloc(sizeof *launcher);
launcher->path = strdup(path);
launcher->icon = load_cairo_surface(icon); launcher->icon = load_cairo_surface(icon);
if ( !launcher->icon || if ( !launcher->icon ||
cairo_surface_status (launcher->icon) != CAIRO_STATUS_SUCCESS) { cairo_surface_status (launcher->icon) != CAIRO_STATUS_SUCCESS) {
@@ -404,6 +403,7 @@ tablet_shell_add_launcher(struct tablet *tablet,
free(launcher); free(launcher);
return; return;
} }
launcher->path = strdup(path);
launcher->homescreen = homescreen; launcher->homescreen = homescreen;
launcher->widget = widget_add_widget(homescreen->widget, launcher); launcher->widget = widget_add_widget(homescreen->widget, launcher);