From cd94a46b971ff06df8ce455f71d904be636dc6e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Wed, 18 Mar 2015 17:08:23 +0800 Subject: [PATCH] xdg-shell: Require a buffer and a wl_surface.commit for mapping a window MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Require the client to have attached (either previously committed, or newly) a buffer to the corresponding wl_surface, and that the window will not be potentially mapped until calling wl_surface.commit after having created the window. This is required to make valid double buffered xdg_surface state possible when creating a window. Currently there is no double buffered state in xdg_popup, but it should behave the same as xdg_surface, and for making it future proof in case we want to add double buffered state to xdg_popup. Signed-off-by: Jonas Ådahl Acked-by: Pekka Paalanen --- protocol/xdg-shell.xml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/protocol/xdg-shell.xml b/protocol/xdg-shell.xml index df103c47..79e30a01 100644 --- a/protocol/xdg-shell.xml +++ b/protocol/xdg-shell.xml @@ -132,6 +132,19 @@ It provides requests to treat surfaces like windows, allowing to set properties like maximized, fullscreen, minimized, and to move and resize them, and associate metadata like title and app id. + + The client must call wl_surface.commit on the corresponding wl_surface + for the xdg_surface state to take effect. Prior to committing the new + state, it can set up initial configuration, such as maximizing or setting + a window geometry. + + Even without attaching a buffer the compositor must respond to initial + committed configuration, for instance sending a configure event with + expected window geometry if the client maximized its surface during + initialization. + + For a surface to be mapped by the compositor the client must have + committed both an xdg_surface state and a buffer. @@ -456,6 +469,12 @@ The x and y arguments specify where the top left of the popup should be placed, relative to the local surface coordinates of the parent surface. + + The client must call wl_surface.commit on the corresponding wl_surface + for the xdg_popup state to take effect. + + For a surface to be mapped by the compositor the client must have + committed both the xdg_popup state and a buffer.