From d0e2ef7779b0fc70f13a8c2191758f5822bc320a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kristian=20H=C3=B8gsberg?= Date: Sun, 19 Feb 2012 22:15:21 -0500 Subject: [PATCH] compositor: Surface is unmapped when surface->output is NULL surface->buffer can be NULL, which happens when a client destroys the attached buffer. Fixes list corruption on resize. --- src/compositor.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/compositor.c b/src/compositor.c index 2992ee6c..8339e6c8 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -1114,7 +1114,7 @@ surface_attach(struct wl_client *client, { struct weston_surface *es = resource->data; struct weston_shell *shell = es->compositor->shell; - struct wl_buffer *buffer, *prev; + struct wl_buffer *buffer; if (!buffer_resource && !es->output) return; @@ -1134,12 +1134,11 @@ surface_attach(struct wl_client *client, buffer = buffer_resource->data; buffer->busy_count++; - prev = es->buffer; es->buffer = buffer; wl_list_insert(es->buffer->resource.destroy_listener_list.prev, &es->buffer_destroy_listener.link); - if (prev == NULL) { + if (es->output == NULL) { shell->map(shell, es, buffer->width, buffer->height, sx, sy); } else if (sx != 0 || sy != 0 || es->geometry.width != buffer->width ||