From db9993875e6397d861c0029a8d2d1027fb27d2f3 Mon Sep 17 00:00:00 2001 From: Rob Bradford Date: Thu, 6 Dec 2012 12:07:48 +0000 Subject: [PATCH] shell: Remove confusing case fall-through This avoids calling weston_surface_set_position twice on the same surface. The second call has no effect in many cases because sx and sy are usually zero on this path. This change now means that any sx/sy values passed into ::attach will be ignored on the first attach for popup surfaces. This similar to the behaviour for other surface types. --- src/shell.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/shell.c b/src/shell.c index 232d4133..aa1c7c18 100644 --- a/src/shell.c +++ b/src/shell.c @@ -2922,6 +2922,7 @@ map(struct desktop_shell *shell, struct weston_surface *surface, break; case SHELL_SURFACE_POPUP: shell_map_popup(shsurf); + break; case SHELL_SURFACE_NONE: weston_surface_set_position(surface, surface->geometry.x + sx,