mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compositor-drm: Avoid cast by using unsigned loop index

Browse Source 
ARRAY_LENGTH returns a size_t; rather than casting its result to
int so we can compare to our signed index variable, just declare the
index as a compatible type in the first place.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
This commit is contained in:
Daniel Stone
2018-07-09 13:49:04 +01:00
parent 7625577a4f
commit dc082cb071
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libweston/compositor-drm.c
+2 -2
View File
@@ -914,7 +914,7 @@ drm_fb_addfb(struct drm_fb *fb)
int ret = -EINVAL; int ret = -EINVAL;
#ifdef HAVE_DRM_ADDFB2_MODIFIERS #ifdef HAVE_DRM_ADDFB2_MODIFIERS
uint64_t mods[4] = { }; uint64_t mods[4] = { };
int i; size_t i;
#endif #endif
/* If we have a modifier set, we must only use the WithModifiers /* If we have a modifier set, we must only use the WithModifiers
@@ -923,7 +923,7 @@ drm_fb_addfb(struct drm_fb *fb)
/* KMS demands that if a modifier is set, it must be the same /* KMS demands that if a modifier is set, it must be the same
* for all planes. */ * for all planes. */
#ifdef HAVE_DRM_ADDFB2_MODIFIERS #ifdef HAVE_DRM_ADDFB2_MODIFIERS
for (i = 0; i < (int) ARRAY_LENGTH(mods) && fb->handles[i]; i++) for (i = 0; i < ARRAY_LENGTH(mods) && fb->handles[i]; i++)
mods[i] = fb->modifier; mods[i] = fb->modifier;
ret = drmModeAddFB2WithModifiers(fb->fd, fb->width, fb->height, ret = drmModeAddFB2WithModifiers(fb->fd, fb->width, fb->height,
fb->format->format, fb->format->format,