From dee14a0a9ef5720f1bc291aa9ead4d67c3c65cdd Mon Sep 17 00:00:00 2001 From: Marius Vlad Date: Thu, 5 Dec 2019 15:07:56 +0200 Subject: [PATCH] clients/simple-dmabuf-egl: Add some notes when using direct-display protocol As dmabuf uses a different coordinate (top-left) system than OpenGL (bottom-left) using both direct-display with the Y_INVERT dmabuf attrib flag would result in the image being inverted (direct-display will remove the Y_INVERT flag, which caused the image to be displayed correctly). Notifies users that direct-display is in use. Signed-off-by: Marius Vlad Suggested-by: Pekka Paalanen --- clients/simple-dmabuf-egl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/clients/simple-dmabuf-egl.c b/clients/simple-dmabuf-egl.c index acd79bfc..10e72a9b 100644 --- a/clients/simple-dmabuf-egl.c +++ b/clients/simple-dmabuf-egl.c @@ -409,6 +409,9 @@ create_dmabuf_buffer(struct display *display, struct buffer *buffer, /* turn off Y_INVERT otherwise linux-dmabuf will reject it and * we need all dmabuf flags turned off */ flags &= ~ZWP_LINUX_BUFFER_PARAMS_V1_FLAGS_Y_INVERT; + + fprintf(stdout, "image is y-inverted as direct-display flag was set, " + "dmabuf y-inverted attribute flag was removed\n"); } for (i = 0; i < buffer->plane_count; ++i) { @@ -1454,7 +1457,10 @@ print_usage_and_exit(void) "\t'-m,--mandelbrot'" "\n\t\trender a mandelbrot set with multiple draw calls\n" "\t'-g,--direct-display'" - "\n\t\tenables weston-direct-display extension to attempt direct scan-out\n"); + "\n\t\tenables weston-direct-display extension to attempt " + "direct scan-out;\n\t\tnote this will cause the image to be " + "displayed inverted as GL uses a\n\t\tdifferent texture " + "coordinate system\n"); exit(0); }