Fix not checking return value of drmIoctl function call to map dumb buffer
in drm_fb_create_dumb, the return value of the drmIoctl function call to map the dumb buffer was never checked, thus the following "if (ret)" check was invalid as it was checking the previous return value from the above drmModeAddFB call. Signed-off-by: Chris Michael <cp.michael@samsung.com>
This commit is contained in:
committed by
Kristian Høgsberg
parent
ab74562335
commit
eb2074a18b
@@ -268,8 +268,7 @@ drm_fb_create_dumb(struct drm_compositor *ec, unsigned width, unsigned height)
|
|||||||
|
|
||||||
memset(&map_arg, 0, sizeof(map_arg));
|
memset(&map_arg, 0, sizeof(map_arg));
|
||||||
map_arg.handle = fb->handle;
|
map_arg.handle = fb->handle;
|
||||||
drmIoctl(fb->fd, DRM_IOCTL_MODE_MAP_DUMB, &map_arg);
|
ret = drmIoctl(fb->fd, DRM_IOCTL_MODE_MAP_DUMB, &map_arg);
|
||||||
|
|
||||||
if (ret)
|
if (ret)
|
||||||
goto err_add_fb;
|
goto err_add_fb;
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user