weston

History

Frank Binns 77f7daca68 smoke: fix valgrind invalid read errors There are a number of invalid read errors reported by valgrind of the form: ==13428== Invalid read of size 4 ==13428== at 0x405656: advect (smoke.c:116) ==13428== by 0x405E80: redraw_handler (smoke.c:228) ==13428== by 0x40DE74: widget_redraw (window.c:3995) ==13428== by 0x40E02D: surface_redraw (window.c:4053) ==13428== by 0x40E0C9: idle_redraw (window.c:4082) ==13428== by 0x410FC9: display_run (window.c:5561) ==13428== by 0x406518: main (smoke.c:373) ==13428== Address 0xb2c9b14 is 4 bytes after a block of size 160,000 alloc'd ==13428== at 0x4C29DB4: calloc ==13428== by 0x40646B: main (smoke.c:360) This results in invalid rendering when running a debug version of the application. Fix the issue by limiting the maximum values of px and py to 1.5 less than width and height. This prevents reading past the end of the source buffer. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=82287 Signed-off-by: Frank Binns <frank.binns@imgtec.com> Acked-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>		11 years ago
..
calibrator.c	…
clickdot.c	input: Schedule pointer sprite repaint when cursor is set	11 years ago
cliptest.c	cliptest: sync calculate_edges with master copy	11 years ago
desktop-shell.c	desktop-shell: properly set background widget as opaque	11 years ago
dnd.c	weston-dnd --help works	11 years ago
editor.c	editor: do not crash when text input manager is not available	11 years ago
eventdemo.c	…
flower.c	…
fullscreen.c	…
gears.c	…
glmatrix.c	…
image.c	image: don't print redundant error	11 years ago
keyboard.c	keyboard: do not crash when input panel is not available	11 years ago
matrix3.xpm	…
multi-resource.c	multi-resource: remove an unnecessary call of wl_display_get_fd()	11 years ago
nested-client.c	…
nested.c	…
presentation-shm.c	clients: add presentation-shm demo	11 years ago
resizor.c	…
scaler.c	weston-scaler --help works even if not run inside wayland	11 years ago
screenshot.c	…
simple-damage.c	xdg-shell: bump experimental protocol version	11 years ago
simple-egl.c	simple-egl: fix opaque and 16 bits mode options	11 years ago
simple-shm.c	simple-shm: remove an unnecessary call of wl_display_get_fd()	11 years ago
simple-touch.c	…
smoke.c	smoke: fix valgrind invalid read errors	11 years ago
stacking.c	…
subsurfaces.c	…
terminal.c	…
transformed.c	…
weston-info.c	weston-info: report presentation clock	11 years ago
weston-simple-im.c	Replace deprecated xkbcommon symbols with current names	11 years ago
window.c	window : compare version and call appropriate destructor	11 years ago
window.h	…
wscreensaver-glue.c	…
wscreensaver-glue.h	…
wscreensaver.c	…
wscreensaver.h	…