// Copyright 2015 The Gogs Authors. All rights reserved.
// Copyright 2016 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package git
import (
"bytes"
"context"
"fmt"
"io"
"os"
"os/exec"
"strings"
"time"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/process"
"code.gitea.io/gitea/modules/util"
)
var (
// globalCommandArgs global command args for external package setting
globalCommandArgs [ ] string
// defaultCommandExecutionTimeout default command execution timeout duration
defaultCommandExecutionTimeout = 360 * time . Second
)
// DefaultLocale is the default LC_ALL to run git commands in.
const DefaultLocale = "C"
// Command represents a command with its subcommands or arguments.
type Command struct {
name string
args [ ] string
parentContext context . Context
desc string
globalArgsLength int
}
func ( c * Command ) String ( ) string {
if len ( c . args ) == 0 {
return c . name
}
return fmt . Sprintf ( "%s %s" , c . name , strings . Join ( c . args , " " ) )
}
// NewCommand creates and returns a new Git Command based on given command and arguments.
func NewCommand ( ctx context . Context , args ... string ) * Command {
// Make an explicit copy of globalCommandArgs, otherwise append might overwrite it
cargs := make ( [ ] string , len ( globalCommandArgs ) )
copy ( cargs , globalCommandArgs )
return & Command {
name : GitExecutable ,
args : append ( cargs , args ... ) ,
parentContext : ctx ,
globalArgsLength : len ( globalCommandArgs ) ,
}
}
// NewCommandNoGlobals creates and returns a new Git Command based on given command and arguments only with the specify args and don't care global command args
func NewCommandNoGlobals ( args ... string ) * Command {
return NewCommandContextNoGlobals ( DefaultContext , args ... )
}
// NewCommandContextNoGlobals creates and returns a new Git Command based on given command and arguments only with the specify args and don't care global command args
func NewCommandContextNoGlobals ( ctx context . Context , args ... string ) * Command {
return & Command {
name : GitExecutable ,
args : args ,
parentContext : ctx ,
}
}
// SetParentContext sets the parent context for this command
func ( c * Command ) SetParentContext ( ctx context . Context ) * Command {
c . parentContext = ctx
return c
}
// SetDescription sets the description for this command which be returned on
// c.String()
func ( c * Command ) SetDescription ( desc string ) * Command {
c . desc = desc
return c
}
// AddArguments adds new argument(s) to the command.
func ( c * Command ) AddArguments ( args ... string ) * Command {
c . args = append ( c . args , args ... )
return c
}
// RunInDirTimeoutEnvPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirTimeoutEnvPipeline ( env [ ] string , timeout time . Duration , dir string , stdout , stderr io . Writer ) error {
return c . RunInDirTimeoutEnvFullPipeline ( env , timeout , dir , stdout , stderr , nil )
}
// RunInDirTimeoutEnvFullPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer and passes in an io.Reader as stdin.
func ( c * Command ) RunInDirTimeoutEnvFullPipeline ( env [ ] string , timeout time . Duration , dir string , stdout , stderr io . Writer , stdin io . Reader ) error {
return c . RunInDirTimeoutEnvFullPipelineFunc ( env , timeout , dir , stdout , stderr , stdin , nil )
}
// RunInDirTimeoutEnvFullPipelineFunc executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer and passes in an io.Reader as stdin. Between cmd.Start and cmd.Wait the passed in function is run.
func ( c * Command ) RunInDirTimeoutEnvFullPipelineFunc ( env [ ] string , timeout time . Duration , dir string , stdout , stderr io . Writer , stdin io . Reader , fn func ( context . Context , context . CancelFunc ) error ) error {
return c . RunWithContext ( & RunContext {
Env : env ,
Timeout : timeout ,
Dir : dir ,
Stdout : stdout ,
Stderr : stderr ,
Stdin : stdin ,
PipelineFunc : fn ,
} )
}
// RunContext represents parameters to run the command
type RunContext struct {
Env [ ] string
Timeout time . Duration
Dir string
Stdout , Stderr io . Writer
Stdin io . Reader
PipelineFunc func ( context . Context , context . CancelFunc ) error
}
// RunWithContext run the command with context
func ( c * Command ) RunWithContext ( rc * RunContext ) error {
if rc . Timeout == - 1 {
rc . Timeout = defaultCommandExecutionTimeout
}
if len ( rc . Dir ) == 0 {
log . Debug ( "%s" , c )
} else {
log . Debug ( "%s: %v" , rc . Dir , c )
}
desc := c . desc
if desc == "" {
args := c . args [ c . globalArgsLength : ]
var argSensitiveURLIndexes [ ] int
for i , arg := range c . args {
if strings . Contains ( arg , "://" ) && strings . Contains ( arg , "@" ) {
argSensitiveURLIndexes = append ( argSensitiveURLIndexes , i )
}
}
if len ( argSensitiveURLIndexes ) > 0 {
args = make ( [ ] string , len ( c . args ) )
copy ( args , c . args )
for _ , urlArgIndex := range argSensitiveURLIndexes {
args [ urlArgIndex ] = util . NewStringURLSanitizer ( args [ urlArgIndex ] , true ) . Replace ( args [ urlArgIndex ] )
}
}
desc = fmt . Sprintf ( "%s %s [repo_path: %s]" , c . name , strings . Join ( args , " " ) , rc . Dir )
}
ctx , cancel , finished := process . GetManager ( ) . AddContextTimeout ( c . parentContext , rc . Timeout , desc )
defer finished ( )
cmd := exec . CommandContext ( ctx , c . name , c . args ... )
if rc . Env == nil {
cmd . Env = os . Environ ( )
} else {
cmd . Env = rc . Env
}
Disable new signal-based asynchronous goroutine preemption from GO 1.14 in git env (#11237)
As seen in trouble shooting #11032 the new feature of Go 1.14 is causing several second delays in startup in certain situations. Debugging shows it spending several seconds handling SIGURG commands during init:
```
6922:04:51.984234 trace init() ./modules/queue/unique_queue_wrapped.go
remote: ) = 69 <0.000012>
remote: [pid 15984] 22:04:51 write(1, "\ttime taken: 236.761\302\265s\n\n", 25 time taken: 236.761µs
remote:
remote: ) = 25 <0.000011>
remote: [pid 15984] 22:04:51 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
remote: [pid 15984] 22:04:52 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
remote: [pid 15984] 22:04:52 --- SIGURG {si_signo=SIGURG, si_code=SI_TKILL, si_pid=15984, si_uid=0} ---
```
This causes up to 20 seconds added to a push in some cases as it happens for each call of the gitea hook command. This is likely the cause of #10661 as well and would start to effect users once we release 1.12 which would be the first release compiled with Go 1.14. I suspect this is just a slight issue with the upstream implementatation as there have been a few very similar bugs fixed and reported:
https://github.com/golang/go/issues/37741
https://github.com/golang/go/issues/37942
We should revisit this in the future and see if a newer version of Go has solved it, but for now disable this option in the environment that gitea hook runs in to avoid it.
5 years ago
cmd . Env = append (
cmd . Env ,
fmt . Sprintf ( "LC_ALL=%s" , DefaultLocale ) ,
// avoid prompting for credentials interactively, supported since git v2.3
"GIT_TERMINAL_PROMPT=0" ,
// ignore replace references (https://git-scm.com/docs/git-replace)
"GIT_NO_REPLACE_OBJECTS=1" ,
)
cmd . Dir = rc . Dir
cmd . Stdout = rc . Stdout
cmd . Stderr = rc . Stderr
cmd . Stdin = rc . Stdin
if err := cmd . Start ( ) ; err != nil {
return err
}
if rc . PipelineFunc != nil {
err := rc . PipelineFunc ( ctx , cancel )
if err != nil {
cancel ( )
_ = cmd . Wait ( )
return err
}
}
if err := cmd . Wait ( ) ; err != nil && ctx . Err ( ) != context . DeadlineExceeded {
return err
}
return ctx . Err ( )
}
// RunInDirTimeoutPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirTimeoutPipeline ( timeout time . Duration , dir string , stdout , stderr io . Writer ) error {
return c . RunInDirTimeoutEnvPipeline ( nil , timeout , dir , stdout , stderr )
}
// RunInDirTimeoutFullPipeline executes the command in given directory with given timeout,
// it pipes stdout and stderr to given io.Writer, and stdin from the given io.Reader
func ( c * Command ) RunInDirTimeoutFullPipeline ( timeout time . Duration , dir string , stdout , stderr io . Writer , stdin io . Reader ) error {
return c . RunInDirTimeoutEnvFullPipeline ( nil , timeout , dir , stdout , stderr , stdin )
}
// RunInDirTimeout executes the command in given directory with given timeout,
// and returns stdout in []byte and error (combined with stderr).
func ( c * Command ) RunInDirTimeout ( timeout time . Duration , dir string ) ( [ ] byte , error ) {
return c . RunInDirTimeoutEnv ( nil , timeout , dir )
}
// RunInDirTimeoutEnv executes the command in given directory with given timeout,
// and returns stdout in []byte and error (combined with stderr).
func ( c * Command ) RunInDirTimeoutEnv ( env [ ] string , timeout time . Duration , dir string ) ( [ ] byte , error ) {
stdout := new ( bytes . Buffer )
stderr := new ( bytes . Buffer )
if err := c . RunInDirTimeoutEnvPipeline ( env , timeout , dir , stdout , stderr ) ; err != nil {
return nil , ConcatenateError ( err , stderr . String ( ) )
}
if stdout . Len ( ) > 0 && log . IsTrace ( ) {
tracelen := stdout . Len ( )
if tracelen > 1024 {
tracelen = 1024
}
log . Trace ( "Stdout:\n %s" , stdout . Bytes ( ) [ : tracelen ] )
}
return stdout . Bytes ( ) , nil
}
// RunInDirPipeline executes the command in given directory,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirPipeline ( dir string , stdout , stderr io . Writer ) error {
return c . RunInDirFullPipeline ( dir , stdout , stderr , nil )
}
// RunInDirFullPipeline executes the command in given directory,
// it pipes stdout and stderr to given io.Writer.
func ( c * Command ) RunInDirFullPipeline ( dir string , stdout , stderr io . Writer , stdin io . Reader ) error {
return c . RunInDirTimeoutFullPipeline ( - 1 , dir , stdout , stderr , stdin )
}
// RunInDirBytes executes the command in given directory
// and returns stdout in []byte and error (combined with stderr).
func ( c * Command ) RunInDirBytes ( dir string ) ( [ ] byte , error ) {
return c . RunInDirTimeout ( - 1 , dir )
}
// RunInDir executes the command in given directory
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) RunInDir ( dir string ) ( string , error ) {
return c . RunInDirWithEnv ( dir , nil )
}
// RunInDirWithEnv executes the command in given directory
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) RunInDirWithEnv ( dir string , env [ ] string ) ( string , error ) {
stdout , err := c . RunInDirTimeoutEnv ( env , - 1 , dir )
if err != nil {
return "" , err
}
return string ( stdout ) , nil
}
// RunTimeout executes the command in default working directory with given timeout,
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) RunTimeout ( timeout time . Duration ) ( string , error ) {
stdout , err := c . RunInDirTimeout ( timeout , "" )
if err != nil {
return "" , err
}
return string ( stdout ) , nil
}
// Run executes the command in default working directory
// and returns stdout in string and error (combined with stderr).
func ( c * Command ) Run ( ) ( string , error ) {
return c . RunTimeout ( - 1 )
}
// AllowLFSFiltersArgs return globalCommandArgs with lfs filter, it should only be used for tests
func AllowLFSFiltersArgs ( ) [ ] string {
// Now here we should explicitly allow lfs filters to run
filteredLFSGlobalArgs := make ( [ ] string , len ( globalCommandArgs ) )
j := 0
for _ , arg := range globalCommandArgs {
if strings . Contains ( arg , "lfs" ) {
j --
} else {
filteredLFSGlobalArgs [ j ] = arg
j ++
}
}
return filteredLFSGlobalArgs [ : j ]
}