Fix update user (#18878)

3 years ago · 6621710deb
parent f1b1472632
commit 6621710deb
1 changed files with 4 additions and 3 deletions
--- a/models/user/user.go
+++ b/models/user/user.go
@ -868,13 +868,14 @@ func updateUser(ctx context.Context, u *User, changePrimaryEmail bool, cols ...s
 		}

 		if !primaryEmailExist {
-			_, err = e.Insert(&EmailAddress{
+			if _, err := e.Insert(&EmailAddress{
 				Email:       u.Email,
 				UID:         u.ID,
 				IsActivated: true,
 				IsPrimary:   true,
-			})
-			return err
+			}); err != nil {
+				return err
+			}
 		}
 	}