@ -206,6 +206,10 @@ func ListIssues(ctx *context.APIContext) {
// in: query
// description: search string
// type: string
// - name: type
// in: query
// description: filter by type (issues / pulls) if set
// type: string
// responses:
// "200":
// "$ref": "#/responses/IssueList"
@ -241,6 +245,16 @@ func ListIssues(ctx *context.APIContext) {
}
}
var isPull util . OptionalBool
switch ctx . Query ( "type" ) {
case "pulls" :
isPull = util . OptionalBoolTrue
case "issues" :
isPull = util . OptionalBoolFalse
default :
isPull = util . OptionalBoolNone
}
// Only fetch the issues if we either don't have a keyword or the search returned issues
// This would otherwise return all issues if no issues were found by the search.
if len ( keyword ) == 0 || len ( issueIDs ) > 0 || len ( labelIDs ) > 0 {
@ -251,6 +265,7 @@ func ListIssues(ctx *context.APIContext) {
IsClosed : isClosed ,
IssueIDs : issueIDs ,
LabelIDs : labelIDs ,
IsPull : isPull ,
} )
}
@ -475,6 +490,7 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
return
}
issue . Repo = ctx . Repo . Repository
canWrite := ctx . Repo . CanWriteIssuesOrPulls ( issue . IsPull )
err = issue . LoadAttributes ( )
if err != nil {
@ -482,7 +498,7 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
return
}
if ! issue . IsPoster ( ctx . User . ID ) && ! ctx . Repo . C anWrite ( models . UnitTypeIssues ) {
if ! issue . IsPoster ( ctx . User . ID ) && ! canWrite {
ctx . Status ( http . StatusForbidden )
return
}
@ -495,7 +511,7 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
}
// Update or remove the deadline, only if set and allowed
if ( form . Deadline != nil || form . RemoveDeadline != nil ) && ctx . Repo . C anWrite ( models . UnitTypeIssues ) {
if ( form . Deadline != nil || form . RemoveDeadline != nil ) && canWrite {
var deadlineUnix timeutil . TimeStamp
if ( form . RemoveDeadline == nil || ! * form . RemoveDeadline ) && ! form . Deadline . IsZero ( ) {
@ -519,7 +535,7 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
// Pass one or more user logins to replace the set of assignees on this Issue.
// Send an empty array ([]) to clear all assignees from the Issue.
if ctx . Repo . C anWrite ( models . UnitTypeIssues ) && ( form . Assignees != nil || form . Assignee != nil ) {
if canWrite && ( form . Assignees != nil || form . Assignee != nil ) {
oneAssignee := ""
if form . Assignee != nil {
oneAssignee = * form . Assignee
@ -532,7 +548,7 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
}
}
if ctx . Repo . C anWrite ( models . UnitTypeIssues ) && form . Milestone != nil &&
if canWrite && form . Milestone != nil &&
issue . MilestoneID != * form . Milestone {
oldMilestoneID := issue . MilestoneID
issue . MilestoneID = * form . Milestone
@ -618,7 +634,7 @@ func UpdateIssueDeadline(ctx *context.APIContext, form api.EditDeadlineOption) {
return
}
if ! ctx . Repo . CanWrite ( models . UnitTypeIssues ) {
if ! ctx . Repo . CanWriteIssuesOrPulls ( issue . IsPull ) {
ctx . Error ( http . StatusForbidden , "" , "Not repo writer" )
return
}