c81b26b0e5
refactor webhook *NewPost ( #20729 )
...
* refactor webhook *NewPost
* remove empty values
* always show errs.Message
* remove utils.IsValidSlackChannel
* move IsValidSlackChannel to services/webhook package
* binding: handle empty Message case
* make IsValidSlackChannel more strict
2 years ago
750a8465f5
A better go code formatter, and now `make fmt` can run in Windows ( #17684 )
...
* go build / format tools
* re-format imports
3 years ago
dea7a5c5b9
just add some unit tests ( #16291 )
...
* code.gitea.io/gitea/routers/utils coverage: 100.0%
* code.gitea.io/gitea/routers/install 0% -> 5.0%
* ConvertUtf8ToUtf8mb4: make sure DBType is mysql
3 years ago
aa4f9180e4
Clarify the suffices and prefixes of setting.AppSubURL and setting.AppURL ( #12999 )
...
Also removes some unnecessary uses of fmt.Sprintf and adds documentation
strings
Signed-off-by: Andrew Thornton <art27@cantab.net>
4 years ago
74bd9691c6
Re-attempt to delete temporary upload if the file is locked by another process ( #12447 )
...
Replace all calls to os.Remove/os.RemoveAll by retrying util.Remove/util.RemoveAll and remove circular dependencies from util.
Fix #12339
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: silverwind <me@silverwind.io>
4 years ago
be48397945
Slack webhook channel name cannot be empty or just contain an hashtag ( #4786 )
6 years ago
311c83ad17
Allow adding collaborators with (fullname) ( #3103 )
...
* Allow adding collaborators with (fullname)
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
* Refactor username suffix to utils pkg
Signed-off-by: Sasha Varlamov <sasha@sashavarlamov.com>
7 years ago
oliverpool
wxiaoguang
6543
zeripath
Lanre Adelowo
Sasha Varlamov