gitea

History

zeripath 06f968d662 Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 ) Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		3 years ago
..
admin	…
appstate	…
asymkey	Pad GPG Key ID with preceding zeroes (#20878 ) (#20885 )	3 years ago
auth	Fix panic when an invalid oauth2 name is passed (#20820 ) (#20900 )	3 years ago
avatars	…
db	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	3 years ago
fixtures	Fix SQL Query for `SearchTeam` (#20844 ) (#20872 )	3 years ago
foreignreference	…
git	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	3 years ago
issues	Fix missed sort bug (#21006 )	3 years ago
migrations	Add another index for Action table on postgres (#21033 ) (#21054 )	3 years ago
organization	Fix SQL Query for `SearchTeam` (#20844 ) (#20872 )	3 years ago
packages	Fix delete user missed some comments (#21067 ) (#21068 )	3 years ago
perm	Store read access in access for team repo's (#20275 ) (#20276 )	3 years ago
project	…
pull	…
repo	Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 )	3 years ago
unit	…
unittest	…
user	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	3 years ago
webhook	Check webhooks slice length before calling xorm (#20642 ) (#20768 )	3 years ago
action.go	Add another index for Action table on postgres (#21033 ) (#21054 )	3 years ago
action_list.go	…
action_test.go	…
consistency.go	…
error.go	…
fixture_generation.go	…
fixture_test.go	…
main_test.go	…
migrate.go	…
migrate_test.go	…
notification.go	…
notification_test.go	…
org.go	…
org_team.go	…
org_team_test.go	…
org_test.go	…
release.go	…
repo.go	Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 )	3 years ago
repo_activity.go	…
repo_collaboration.go	…
repo_collaboration_test.go	…
repo_test.go	…
repo_transfer.go	…
repo_transfer_test.go	…
statistic.go	…
task.go	…
token.go	…
token_test.go	…
upload.go	…
user.go	Fix delete user missed some comments (#21067 ) (#21068 )	3 years ago
user_heatmap.go	…
user_heatmap_test.go	…