gitea

History

zeripath bbffcc3aec Multiple Escaping Improvements (#17551 ) There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this. This is an extensive PR attempting to fix these issues. 1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping. 2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand. 3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future. 4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.) 5. The title generation in feeds is now properly escaped. 6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>		3 years ago
..
agit	…
archiver	…
attachment	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
auth	Minor readability patch. (#17627 )	3 years ago
comments	…
cron	Move migrations into services and base into modules/migration (#17663 )	3 years ago
externalaccount	Move login related structs and functions to models/login (#17093 )	3 years ago
forms	…
gitdiff	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
issue	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
lfs	Multiple Escaping Improvements (#17551 )	3 years ago
mailer	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
migrations	Move migrations into services and base into modules/migration (#17663 )	3 years ago
mirror	Handle broken references in mirror sync (#17013 )	3 years ago
pull	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
release	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
repository	Move some functions into services/repository (#17660 )	3 years ago
webhook	Multiple Escaping Improvements (#17551 )	3 years ago
wiki	Multiple Escaping Improvements (#17551 )	3 years ago