gitea

History

zeripath 06f968d662 Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 ) Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2 years ago
..
archiver	Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 )	2 years ago
files	Remove legacy git code (ver < 2.0), fine tune markup tests (#19930 )	2 years ago
adopt.go	Move some repository related code into sub package (#19711 )	3 years ago
adopt_test.go	format with gofumpt (#18184 )	3 years ago
avatar.go	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	2 years ago
avatar_test.go	Some repository refactors (#17950 )	3 years ago
branch.go	Move some code into models/git (#19879 )	3 years ago
cache.go	Move repository model into models/repo (#17933 )	3 years ago
check.go	Move some repository related code into sub package (#19711 )	3 years ago
fork.go	Move some code into models/git (#19879 )	3 years ago
fork_test.go	Make git.OpenRepository accept Context (#19260 )	3 years ago
hooks.go	Move some repository related code into sub package (#19711 )	3 years ago
main_test.go	Use a struct as test options (#19393 )	3 years ago
push.go	Move some code into models/git (#19879 )	3 years ago
repository.go	Move issues related files into models/issues (#19931 )	2 years ago
repository_test.go	Move some repository related code into sub package (#19711 )	3 years ago
review.go	Move some repository related code into sub package (#19711 )	3 years ago
review_test.go	Move some repository related code into sub package (#19711 )	3 years ago
template.go	Check issue labels slice length before calling xorm Insert(#20655 ) (#20836 )	2 years ago
transfer.go	Move access and repo permission to models/perm/access (#19350 )	3 years ago
transfer_test.go	Move access and repo permission to models/perm/access (#19350 )	3 years ago