gitea

History

Peter Gardfjäll 4562d40fce fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) * fix hard-coded timeout and error panic in API archive download endpoint This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>		2 years ago
..
activities	Move some files into models' sub packages (#20262 )	2 years ago
admin	Move some files into models' sub packages (#20262 )	2 years ago
appstate	Sync gitea app path for git hooks and authorized keys when starting (#17335 )	3 years ago
asymkey	Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896 )	2 years ago
auth	Move some files into models' sub packages (#20262 )	2 years ago
avatars	format with gofumpt (#18184 )	3 years ago
db	Add migrate repo archiver and packages storage support on command line (#20757 )	2 years ago
fixtures	Fix SQL Query for `SearchTeam` (#20844 )	2 years ago
foreignreference	Store the foreign ID of issues during migration (#18446 )	3 years ago
git	Add migrate repo archiver and packages storage support on command line (#20757 )	2 years ago
issues	Refactor AssertExistsAndLoadBean to use generics (#20797 )	2 years ago
migrations	Increase Content field size of gpg_key and public_key to MEDIUMTEXT (#20896 )	2 years ago
organization	Move some files into models' sub packages (#20262 )	2 years ago
packages	Add support for Vagrant packages (#20930 )	2 years ago
perm	Move some files into models' sub packages (#20262 )	2 years ago
project	Add option to purge users (#18064 )	2 years ago
pull	Delete related PullAutoMerge and ReviewState on User/Repo Deletion (#19649 )	3 years ago
repo	fix hard-coded timeout and error panic in API archive download endpoint (#20925 )	2 years ago
unit	Add more linters to improve code readability (#19989 )	3 years ago
unittest	Refactor AssertExistsAndLoadBean to use generics (#20797 )	2 years ago
user	Move some files into models' sub packages (#20262 )	2 years ago
webhook	Refactor AssertExistsAndLoadBean to use generics (#20797 )	2 years ago
error.go	Move some files into models' sub packages (#20262 )	2 years ago
fixture_generation.go	Move access and repo permission to models/perm/access (#19350 )	3 years ago
fixture_test.go	Decouple unit test code from business code (#17623 )	3 years ago
main_test.go	Move some files into models' sub packages (#20262 )	2 years ago
migrate.go	Move some files into models' sub packages (#20262 )	2 years ago
migrate_test.go	Move some files into models' sub packages (#20262 )	2 years ago
org.go	Move some files into models' sub packages (#20262 )	2 years ago
org_team.go	Move some files into models' sub packages (#20262 )	2 years ago
org_team_test.go	Move some files into models' sub packages (#20262 )	2 years ago
org_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797 )	2 years ago
repo.go	fix hard-coded timeout and error panic in API archive download endpoint (#20925 )	2 years ago
repo_collaboration.go	Move some files into models' sub packages (#20262 )	2 years ago
repo_collaboration_test.go	Move some files into models' sub packages (#20262 )	2 years ago
repo_test.go	Move tests as seperate sub packages to reduce duplicated file names (#19951 )	3 years ago
repo_transfer.go	Move some files into models' sub packages (#20262 )	2 years ago
repo_transfer_test.go	Refactor AssertExistsAndLoadBean to use generics (#20797 )	2 years ago
user.go	Move some files into models' sub packages (#20262 )	2 years ago