gitea

History

Jason Song 77c89572e9 Fix isAllowed of escapeStreamer (#22814 ) (#22837 ) Backport #22814. The use of `sort.Search` is wrong: The slice should be sorted, and `return >= 0` doen't mean it exists, see the [manual](https://pkg.go.dev/sort#Search). Could be fixed like this if we really need it: ```diff diff --git a/modules/charset/escape_stream.go b/modules/charset/escape_stream.go index 823b63513..fcf1ffbc1 100644 --- a/modules/charset/escape_stream.go +++ b/modules/charset/escape_stream.go @@ -20,6 +20,9 @@ import ( var defaultWordRegexp = regexp.MustCompile(`(-?\d\.\d\w)\|([^\` + "`" + `\~\!\@\#\$\%\^\&\\-\=\+\[\{\]\}\\\\|\;\:\'\"\,\.\<\>\/\?\s\x00-\x1f]+)`) func NewEscapeStreamer(locale translation.Locale, next HTMLStreamer, allowed ...rune) HTMLStreamer { + sort.Slice(allowed, func(i, j int) bool { + return allowed[i] < allowed[j] + }) return &escapeStreamer{ escaped: &EscapeStatus{}, PassthroughHTMLStreamer: NewPassthroughStreamer(next), @@ -284,14 +287,8 @@ func (e escapeStreamer) runeTypes(runes ...rune) (types []runeType, confusables } func (e escapeStreamer) isAllowed(r rune) bool { - if len(e.allowed) == 0 { - return false - } - if len(e.allowed) == 1 { - return e.allowed[0] == r - } - - return sort.Search(len(e.allowed), func(i int) bool { + i := sort.Search(len(e.allowed), func(i int) bool { return e.allowed[i] >= r - }) >= 0 + }) + return i < len(e.allowed) && e.allowed[i] == r } ``` But I don't think so, a map is better to do it.		2 years ago
..
activitypub	Fix dashboard ignored system setting cache (#21621 ) (#21759 )	2 years ago
analyze	Simplify `IsVendor` (#19626 )	3 years ago
auth	Remove legacy `+build:` constraint (#19582 )	3 years ago
avatar	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
base	Add generic set type (#21408 )	2 years ago
cache	Fix get system setting bug when enabled redis cache (#22298 )	2 years ago
charset	Fix isAllowed of escapeStreamer (#22814 ) (#22837 )	2 years ago
container	Add generic set type (#21408 )	2 years ago
context	Prepend refs/heads/ to issue template refs (#20461 ) (#22427 )	2 years ago
convert	Fix pull request API field `closed_at` always being `null` (#22482 ) (#22483 )	2 years ago
csv	Go 1.19 format (#20758 )	2 years ago
doctor	Prevent dangling user redirects (#21856 ) (#21858 )	2 years ago
emoji	Update Emoji dataset to Unicode 14 (#22342 ) (#22343 )	2 years ago
eventsource	Move some files into models' sub packages (#20262 )	2 years ago
generate	Use base32 for 2FA scratch token (#18384 )	3 years ago
git	Prepend refs/heads/ to issue template refs (#20461 ) (#22427 )	2 years ago
gitgraph	Refactor git command arguments and make all arguments to be safe to be used (#21535 )	2 years ago
graceful	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
hcaptcha	hCaptcha Support (#12594 )	4 years ago
highlight	Upgrade chroma to v2.3.0 (#21259 )	2 years ago
hostmatcher	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
httpcache	Add Cache-Control header to html and api responses, add no-transform (#20432 )	2 years ago
httplib	refactor httplib (#18338 )	3 years ago
indexer	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
issue/template	Use path not filepath in template filenames (#21993 ) (#22022 )	2 years ago
json	Refactor legacy `unknwon/com` package, improve golangci lint (#19284 )	3 years ago
lfs	Removed some vestigial code related to Range bounds checks (#20312 )	2 years ago
log	upgrade golangcilint to v1.51.0 (#22764 )	2 years ago
markup	Fix README TOC links (#22577 ) (#22677 )	2 years ago
mcaptcha	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
metrics	Move some files into models' sub packages (#20262 )	2 years ago
migration	Fix restore repo bug, clarify the problem of ForeignIndex (#22776 ) (#22794 )	2 years ago
mirror	Implement sync push mirror on commit (#19411 )	2 years ago
nosql	fix broken insecureskipverify handling in rediss connection uris (#20967 )	2 years ago
notification	Link issue and pull requests status change in UI notifications directly to their event in the timelined view. (#22627 ) (#22642 )	2 years ago
options	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
packages	Use import of OCI structs (#22765 ) (#22805 )	2 years ago
paginator	Remove unnecessary misspell ignore pattern (#21475 )	2 years ago
password	Fixed assert statements. (#16089 )	3 years ago
pprof	Go 1.19 format (#20758 )	2 years ago
private	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
process	Add more linters to improve code readability (#19989 )	2 years ago
proxy	Return nil proxy function if proxy not enabled (#16742 )	3 years ago
proxyprotocol	Support Proxy protocol (#12527 )	2 years ago
public	Add generic set type (#21408 )	2 years ago
queue	Correctly handle select on multiple channels in Queues (#22146 ) (#22428 )	2 years ago
recaptcha	Replace all instances of fmt.Errorf(%v) with fmt.Errorf(%w) (#21551 )	2 years ago
references	Remove unnecessary misspell ignore pattern (#21475 )	2 years ago
regexplru	Custom regexp external issues (#17624 )	2 years ago
repository	Fix error when calculate the repository size (#22392 ) (#22474 )	2 years ago
secret	Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439 )	3 years ago
session	format with gofumpt (#18184 )	3 years ago
setting	upgrade golangcilint to v1.51.0 (#22764 )	2 years ago
sitemap	Fix sitemap (#22272 ) (#22320 )	2 years ago
ssh	Support Proxy protocol (#12527 )	2 years ago
storage	Local storage should not store files as executable (#22162 ) (#22163 )	2 years ago
structs	Add `sync_on_commit` option for push mirrors api (#22271 ) (#22292 )	2 years ago
svg	Remove legacy `+build:` constraint (#19582 )	3 years ago
sync	Add generic set type (#21408 )	2 years ago
system	Fix dashboard ignored system setting cache (#21621 ) (#21759 )	2 years ago
templates	Display error log when a modified template has an error so that it could recovery when the error fixed (#22261 ) (#22321 )	2 years ago
test	Refactor AssertExistsAndLoadBean to use generics (#20797 )	2 years ago
timeutil	Check for zero time instant in TimeStamp.IsZero() (#22171 ) (#22172 )	2 years ago
translation	Make every not exist error unwrappable to a fs.ErrNotExist (#20891 )	2 years ago
typesniffer	Rework raw file http header logic (#20484 )	2 years ago
updatechecker	Add system setting table with cache and also add cache supports for user setting (#18058 )	2 years ago
upload	Simplify parameter types (#18006 )	3 years ago
uri	Prevent NPE if gitea uploader fails to open url (#18080 )	3 years ago
user	Add gitea-vet (#10948 )	5 years ago
util	Improve checkIfPRContentChanged (#22611 ) (#22644 )	2 years ago
validation	Add more checks in migration code (#21011 )	2 years ago
watcher	Share HTML template renderers and create a watcher framework (#20218 )	2 years ago
web	refactor webhook *NewPost (#20729 )	2 years ago