gitea

History

zeripath bbffcc3aec Multiple Escaping Improvements (#17551 ) There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this. This is an extensive PR attempting to fix these issues. 1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping. 2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand. 3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future. 4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.) 5. The title generation in feeds is now properly escaped. 6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>		3 years ago
..
activity.go	Move unit into models/unit/ (#17576 )	3 years ago
attachment.go	Add repo_id for attachment (#16958 )	3 years ago
blame.go	Multiple Escaping Improvements (#17551 )	3 years ago
branch.go	Move unit into models/unit/ (#17576 )	3 years ago
commit.go	Multiple Escaping Improvements (#17551 )	3 years ago
compare.go	Multiple Escaping Improvements (#17551 )	3 years ago
download.go	Download lfs in git and web workflow from minio/s3 directly (#16731 )	3 years ago
editor.go	Multiple Escaping Improvements (#17551 )	3 years ago
editor_test.go	Decouple unit test code from business code (#17623 )	3 years ago
http.go	Move EmailAddress & UserRedirect into models/user/ (#17607 )	3 years ago
http_test.go	Fix http path bug (#16117 )	4 years ago
issue.go	Multiple Escaping Improvements (#17551 )	3 years ago
issue_content_history.go	Move unit into models/unit/ (#17576 )	3 years ago
issue_dependency.go	Rename context.Query to context.Form (#16562 )	3 years ago
issue_label.go	Move login related structs and functions to models/login (#17093 )	3 years ago
issue_label_test.go	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
issue_lock.go	…
issue_stopwatch.go	Multiple Escaping Improvements (#17551 )	3 years ago
issue_test.go	Hide label comments if labels were added and removed immediately (#17455 )	3 years ago
issue_timetrack.go	…
issue_watch.go	…
lfs.go	Multiple Escaping Improvements (#17551 )	3 years ago
main_test.go	Decouple unit test code from business code (#17623 )	3 years ago
middlewares.go	Rename ctx.Form() to ctx.FormString() and move code into own file (#16571 )	3 years ago
migrate.go	Multiple Escaping Improvements (#17551 )	3 years ago
milestone.go	Multiple Escaping Improvements (#17551 )	3 years ago
projects.go	Multiple Escaping Improvements (#17551 )	3 years ago
projects_test.go	Decouple unit test code from business code (#17623 )	3 years ago
pull.go	Multiple Escaping Improvements (#17551 )	3 years ago
pull_review.go	Rename ctx.Form() to ctx.FormString() and move code into own file (#16571 )	3 years ago
release.go	Multiple Escaping Improvements (#17551 )	3 years ago
release_test.go	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
repo.go	Multiple Escaping Improvements (#17551 )	3 years ago
search.go	Related refactors to ctx.FormX functions (#16567 )	3 years ago
setting.go	Multiple Escaping Improvements (#17551 )	3 years ago
setting_protected_branch.go	Multiple Escaping Improvements (#17551 )	3 years ago
settings_test.go	Decouple unit test, remove intermediate `unittestbridge` package (#17662 )	3 years ago
tag.go	Multiple Escaping Improvements (#17551 )	3 years ago
topic.go	Related refactors to ctx.FormX functions (#16567 )	3 years ago
view.go	Multiple Escaping Improvements (#17551 )	3 years ago
webhook.go	Multiple Escaping Improvements (#17551 )	3 years ago
wiki.go	Multiple Escaping Improvements (#17551 )	3 years ago
wiki_test.go	Multiple Escaping Improvements (#17551 )	3 years ago