You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

zeripath bbffcc3aec Multiple Escaping Improvements (#17551) ... There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this. This is an extensive PR attempting to fix these issues. 1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping. 2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand. 3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future. 4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.) 5. The title generation in feeds is now properly escaped. 6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>		3 years ago
..
blob_excerpt.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
box.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
comment_form.tmpl	Fix spelling (#16179)	3 years ago
comment_form_datahandler.tmpl	Pull request review/approval and comment on code (#3748)	6 years ago
comments.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
compare.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
conversation.tmpl	Fix previous/next button size (#16284)	3 years ago
csv_diff.tmpl	Prevent NPE in CSV diff rendering when column removed (#17018)	3 years ago
image_diff.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
new_comment.tmpl	Do not reload page after adding comments in Pull Request reviews (#13877)	4 years ago
new_review.tmpl	Add attachments for PR reviews (#16075)	3 years ago
options_dropdown.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
section_split.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
section_unified.tmpl	Multiple Escaping Improvements (#17551)	3 years ago
stats.tmpl	Search and Diff CSS enhancements (#14050)	4 years ago
whitespace_dropdown.tmpl	Comment box tweaks and SVG dropdown triangles (#13376)	4 years ago