gitea

History

zeripath 06f968d662 Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 ) Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2 years ago
..
admin.go	Move some repository related code into sub package (#19711 )	2 years ago
admin_auth_ldap.go	Add LDAP group sync to Teams, fixes #1395 (#16299 )	3 years ago
admin_auth_ldap_test.go	…
cert.go	…
cmd.go	fix: some typos (#19956 )	2 years ago
convert.go	…
docs.go	…
doctor.go	Disable doctor logging on panic (#20847 ) (#20898 )	2 years ago
dump.go	Dump should only copy regular files and symlink regular files (#20015 ) (#20021 )	2 years ago
dump_repo.go	Make sure `repo_dir` is an empty directory or doesn't exist before 'dump-repo' (#20205 ) (#20370 )	2 years ago
embedded.go	…
embedded_stub.go	…
generate.go	…
hook.go	Remove legacy git code (ver < 2.0), fine tune markup tests (#19930 )	2 years ago
hook_test.go	…
keys.go	…
mailer.go	…
main_test.go	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	2 years ago
manager.go	…
manager_logging.go	…
migrate.go	…
migrate_storage.go	Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 )	2 years ago
migrate_storage_test.go	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	2 years ago
restore_repo.go	Fix cli command restore-repo: "units" should be parsed as cli.String (#20183 ) (#20187 )	2 years ago
serv.go	Move some code into models/git (#19879 )	2 years ago
web.go	Add fgprof pprof profiler (#20005 )	2 years ago
web_acme.go	Update go deps (#19665 )	3 years ago
web_graceful.go	…
web_https.go	…