gitea

History

zeripath 06f968d662 Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 ) Backport #20925 This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}` endpoint which prior to this PR had a couple of issues. 1. The endpoint had a hard-coded 20s timeout for the archiver to complete after which a 500 (Internal Server Error) was returned to client. For a scripted API client there was no clear way of telling that the operation timed out and that it should retry. 2. Whenever the timeout _did occur_, the code used to panic. This was caused by the API endpoint "delegating" to the same call path as the web, which uses a slightly different way of reporting errors (HTML rather than JSON for example). More specifically, `api/v1/repo/file.go#GetArchive` just called through to `web/repo/repo.go#Download`, which expects the `Context` to have a `Render` field set, but which is `nil` for API calls. Hence, a `nil` pointer error. The code addresses (1) by dropping the hard-coded timeout. Instead, any timeout/cancelation on the incoming `Context` is used. The code addresses (2) by updating the API endpoint to use a separate call path for the API-triggered archive download. This avoids producing HTML-errors on errors (it now produces JSON errors). Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>		2 years ago
..
archiver.go	Fix hard-coded timeout and error panic in API archive download endpoint (#20925 ) (#21051 )	2 years ago
attachment.go	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	2 years ago
attachment_test.go	Move some repository related code into sub package (#19711 )	2 years ago
avatar.go	Move almost all functions' parameter db.Engine to context.Context (#19748 )	3 years ago
collaboration.go	Move some code into models/git (#19879 )	2 years ago
collaboration_test.go	Move tests as seperate sub packages to reduce duplicated file names (#19951 )	2 years ago
fork.go	Feature: Find files in repo (#15028 )	2 years ago
fork_test.go	Move some repository related code into sub package (#19711 )	2 years ago
git.go	Move repository model into models/repo (#17933 )	3 years ago
issue.go	Prevent deadlock in create issue (#17970 )	3 years ago
language_stats.go	Move almost all functions' parameter db.Engine to context.Context (#19748 )	3 years ago
main_test.go	Feature: Find files in repo (#15028 )	2 years ago
mirror.go	In PushMirrorsIterate and MirrorsIterate if limit is negative do not set it (#20837 ) (#20899 )	2 years ago
pushmirror.go	In PushMirrorsIterate and MirrorsIterate if limit is negative do not set it (#20837 ) (#20899 )	2 years ago
pushmirror_test.go	Move some repository related code into sub package (#19711 )	2 years ago
redirect.go	Some repository refactors (#17950 )	3 years ago
redirect_test.go	Move some repository related code into sub package (#19711 )	2 years ago
repo.go	Move issues related files into models/issues (#19931 )	2 years ago
repo_indexer.go	Move almost all functions' parameter db.Engine to context.Context (#19748 )	3 years ago
repo_list.go	Add migrate repo archiver and packages storage support on command line (#20757 ) (#20806 )	2 years ago
repo_list_test.go	Move some repository related code into sub package (#19711 )	2 years ago
repo_test.go	Move tests as seperate sub packages to reduce duplicated file names (#19951 )	2 years ago
repo_unit.go	Custom regexp external issues (#17624 )	2 years ago
star.go	Move almost all functions' parameter db.Engine to context.Context (#19748 )	3 years ago
star_test.go	Move some repository related code into sub package (#19711 )	2 years ago
topic.go	Move almost all functions' parameter db.Engine to context.Context (#19748 )	3 years ago
topic_test.go	Move some repository related code into sub package (#19711 )	2 years ago
update.go	Move some repository related code into sub package (#19711 )	2 years ago
user_repo.go	Move some repository related code into sub package (#19711 )	2 years ago
user_repo_test.go	Move some repository related code into sub package (#19711 )	2 years ago
watch.go	Move almost all functions' parameter db.Engine to context.Context (#19748 )	3 years ago
watch_test.go	Move some repository related code into sub package (#19711 )	2 years ago
wiki.go	Move repository model into models/repo (#17933 )	3 years ago
wiki_test.go	Move some repository related code into sub package (#19711 )	2 years ago