3 Commits

Author SHA1 Message Date
Nikita Tokarchuk fd53c66690 Use ordered document for index model 2020-03-25 17:40:26 +01:00
Nikita Tokarchuk 6111341a3c Check for nil interface correctly 2020-03-24 21:31:29 +01:00
Nikita Tokarchuk 9f647ca094 Allow nil query in composer 2020-03-19 00:44:48 +01:00
6 changed files with 66 additions and 9 deletions
+2 -1
View File
@@ -6,6 +6,7 @@ import (
"go.mongodb.org/mongo-driver/bson/primitive"
"github.com/mainnika/mongox-go-driver/v2/mongox"
"github.com/mainnika/mongox-go-driver/v2/mongox/utils"
)
// GetID returns source document id
@@ -62,7 +63,7 @@ func getObjectOrPanic(source mongox.JSONBased) (id primitive.D) {
func getInterfaceOrPanic(source mongox.InterfaceBased) (id interface{}) {
id = source.GetID()
if id != nil {
if !utils.IsNil(id) {
return id
}
+2 -1
View File
@@ -10,6 +10,7 @@ import (
"github.com/mainnika/mongox-go-driver/v2/mongox"
"github.com/mainnika/mongox-go-driver/v2/mongox/base"
"github.com/mainnika/mongox-go-driver/v2/mongox/query"
"github.com/mainnika/mongox-go-driver/v2/mongox/utils"
)
// DeleteOne removes a document from a database and then returns it into target
@@ -22,7 +23,7 @@ func (d *Database) DeleteOne(target interface{}, filters ...interface{}) error {
opts.Sort = composed.Sorter()
if target != nil {
if !utils.IsNil(target) {
composed.And(primitive.M{"_id": base.GetID(target)})
}
+4 -4
View File
@@ -64,15 +64,15 @@ func (d *Database) IndexEnsure(cfg interface{}, document interface{}) error {
panic(fmt.Errorf("cannot evaluate index key"))
}
index := primitive.M{key: 1}
opts := &options.IndexOptions{
Background: &f,
Unique: &f,
Name: &name,
}
index := primitive.D{{Key: key, Value: 1}}
if indexValues[0] == "-" {
index[key] = -1
index = primitive.D{{Key: key, Value: -1}}
}
for _, prop := range indexValues[1:] {
@@ -114,9 +114,9 @@ func (d *Database) IndexEnsure(cfg interface{}, document interface{}) error {
}
if compoundValue[0] == '-' {
index[compoundValue[1:]] = -1
index = append(index, primitive.E{compoundValue[1:], -1})
} else {
index[compoundValue] = 1
index = append(index, primitive.E{compoundValue, 1})
}
default:
+5 -3
View File
@@ -7,6 +7,7 @@ import (
"go.mongodb.org/mongo-driver/bson/primitive"
"github.com/mainnika/mongox-go-driver/v2/mongox/base/protection"
"github.com/mainnika/mongox-go-driver/v2/mongox/utils"
)
// Compose is a function to compose filters into a single query
@@ -26,6 +27,10 @@ func Compose(filters ...interface{}) *Query {
// Push applies single filter to a query
func Push(q *Query, f interface{}) bool {
if utils.IsNil(f) {
return true
}
ok := false
ok = ok || applyBson(q, f)
ok = ok || applyLimit(q, f)
@@ -91,9 +96,6 @@ func applyProtection(q *Query, f interface{}) bool {
x = &f.X
v = &f.V
case *protection.Key:
if f == nil {
return false
}
x = &f.X
v = &f.V
+21
View File
@@ -0,0 +1,21 @@
package utils
import (
"unsafe"
)
// IsNil function evaluates the interface value to nil
func IsNil(i interface{}) bool {
type iface struct {
_ *interface{}
ptr unsafe.Pointer
}
unpacked := (*iface)(unsafe.Pointer(&i))
if unpacked.ptr == nil {
return true
}
return *(*unsafe.Pointer)(unpacked.ptr) == nil
}
+32
View File
@@ -0,0 +1,32 @@
package utils
import (
"testing"
"github.com/stretchr/testify/assert"
)
func TestIsNil(t *testing.T) {
testvalues := []struct {
i interface{}
isnil bool
}{
{nil, true},
{(*string)(nil), true},
{([]string)(nil), true},
{(map[string]string)(nil), true},
{(func() bool)(nil), true},
{(chan func() bool)(nil), true},
{"", true},
{0, true},
{append(([]string)(nil), ""), false},
{[]string{}, false},
{1, false},
{"1", false},
}
for _, tt := range testvalues {
assert.Equal(t, tt.isnil, IsNil(tt.i))
}
}