shell: Test for surface->width == 0 to see if input-panel was unmapped

The input-panel codes tries to see determine if a buffer has not yet
been attached (or a NULL buffer has been attached), and doesn't map
the input panel surface yet in that case.  However, it test for
buffer_ref being NULL, which can happen for other reasons.  The right
test is to see if surface->width is 0, which means that either a
buffer hasn't yet been attached or a NULL buffer has been attached.

https://bugs.freedesktop.org/show_bug.cgi?id=72519
dev
Kristian Høgsberg 11 years ago
parent c30c8a3db5
commit 2eebcd34fc
  1. 2
      desktop-shell/input-panel.c

@ -68,7 +68,7 @@ show_input_panels(struct wl_listener *listener, void *data)
wl_list_for_each_safe(ipsurf, next, wl_list_for_each_safe(ipsurf, next,
&shell->input_panel.surfaces, link) { &shell->input_panel.surfaces, link) {
if (!ipsurf->surface->buffer_ref.buffer) if (ipsurf->surface->width == 0)
continue; continue;
wl_list_insert(&shell->input_panel_layer.view_list, wl_list_insert(&shell->input_panel_layer.view_list,
&ipsurf->view->layer_link); &ipsurf->view->layer_link);

Loading…
Cancel
Save