mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

compositor-drm: Remove addfb warning for user buffers

Browse Source 
THe KMS AddFB call can fail for any reason at all: format/modifier not
suitable, stride not aligned, allocation not contiguous, etc. If this
happens with Weston's own buffers, the result is bad - no composition
output.

Failing AddFB from user-supplied buffers though, is not an error. The
user can't necessarily allocate suitable buffers, nor does it have to.
Don't spam the log with warnings when we fail on user buffers.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Reported-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Derek Foreman <derek.foreman.samsung@gmail.com>
This commit is contained in:
Daniel Stone
2018-07-12 12:16:47 +01:00
committed by Derek Foreman
parent 1178922590
commit 48687982b5
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libweston/compositor-drm.c
+3 -4
View File
@@ -1168,10 +1168,8 @@ drm_fb_get_from_dmabuf(struct linux_dmabuf_buffer *dmabuf,
goto err_free;
}
if (drm_fb_addfb(fb) != 0) {
weston_log("failed to create kms fb: %m\n");
if (drm_fb_addfb(fb) != 0)
goto err_free;
}
return fb;
@@ -1242,7 +1240,8 @@ drm_fb_get_from_bo(struct gbm_bo *bo, struct drm_backend *backend,
}
if (drm_fb_addfb(fb) != 0) {
weston_log("failed to create kms fb: %m\n");
if (type == BUFFER_GBM_SURFACE)
weston_log("failed to create kms fb: %m\n");
goto err_free;
}