In drm_output_prepare_plane_view() we iterate the list of planes and add them as candidates to promote the view to one of them. Cursor planes do not support buffers other than wl_shm (at least for now). So when we have a dmabuf or an EGL buffer in the view, the function drm_output_plane_cursor_has_valid_format() returns false and the cursor plane is not added to the candidate list. In this patch we move the responsibility of doing this from drm_output_plane_cursor_has_valid_format() to drm_output_prepare_plane_view() itself, as the incompatibility between other types of buffers and cursor planes is different from the incompatibility between formats. This makes the code easier to read and also documents the current incompatibility between cursor planes and buffers that are not created through wl_shm. Signed-off-by: Leandro Ribeiro <leandro.ribeiro@collabora.com>dev
parent
2984f36c72
commit
4b5df8b39f
Loading…
Reference in new issue