When all shared/ headers are included in the same way, we can drop unnecessary include seach paths from the compiler. This include style was chosen because it is prevalent in the code base. Doing anything different would have been a bigger patch. This also means that we need to keep the project root directory in the include search path, which means that one could accidentally include private headers with #include "libweston/dbus.h" or even #include <libweston/dbus.h> IMO such problem is smaller than the churn caused by any of the alternatives, and we should be able to catch those in review. We might even be able to catch those with grep in CI if necessary. The "bad" include style was found with: $ for h in shared/*.h; do git grep -F $(basename $h); done | grep -vF '"shared/' Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.com>dev
parent
acf84fd29f
commit
c232f8d934
Loading…
Reference in new issue