mainnika/weston
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

terminal: Fix unintended fallthrough to cursor restore

Browse Source 
ef57a9b788 added support for window operations such as reporting the
title in escape mode. It implemented this by which-window-op case,
inside the existing which-escape-code case. Whilst it would break out of
the former window-op case, it never broke out of the latter escape-code
case. This would lead to window ops (such as reporting title) falling
through to restoring the saved cursor position.

This doesn't seem at all right, and also fixes a warning with GCC 8.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Derek Foreman <derekf@osg.samsung.com>
This commit is contained in:
Daniel Stone
2018-04-03 19:38:09 +01:00
committed by Derek Foreman
parent 10fe82fe2d
commit ee96ce2fc2
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
clients/terminal.c
+1
View File
@@ -1686,6 +1686,7 @@ handle_escape(struct terminal *terminal)
fprintf(stderr, "Unimplemented windowOp %d\n", args[0]); fprintf(stderr, "Unimplemented windowOp %d\n", args[0]);
break; break;
} }
break;
case 'u': /* Restore cursor location */ case 'u': /* Restore cursor location */
terminal->row = terminal->saved_row; terminal->row = terminal->saved_row;
terminal->column = terminal->saved_column; terminal->column = terminal->saved_column;