Fix login with email for ldap users (#18800)

`authenticator.Authenticate` has assume the login name is not an email, but `username` maybe an email. So when we find the user via email address, we should use `user.LoginName` instead of `username` which is an email address.
tokarchuk/v1.17
Lunny Xiao 3 years ago committed by GitHub
parent d5a4c5530a
commit 00be0c1b21
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      services/auth/signin.go

@ -65,7 +65,7 @@ func UserSignIn(username, password string) (*user_model.User, *auth.Source, erro
return nil, nil, smtp.ErrUnsupportedLoginType return nil, nil, smtp.ErrUnsupportedLoginType
} }
user, err := authenticator.Authenticate(user, username, password) user, err := authenticator.Authenticate(user, user.LoginName, password)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }

Loading…
Cancel
Save