Fix deadline on update issue or PR via API (#8696)

* Fix deadline on update issue or PR via API

* variable initialized directly (review comment)

routers/api/v1/repo/issue.go

@@ -336,14 +336,13 @@ func EditIssue(ctx *context.APIContext, form api.EditIssueOption) {
 	}
 
 	// Update the deadline
-	var deadlineUnix timeutil.TimeStamp
+	if form.Deadline != nil && ctx.Repo.CanWrite(models.UnitTypeIssues) {
-	if form.Deadline != nil && !form.Deadline.IsZero() && ctx.Repo.CanWrite(models.UnitTypeIssues) {
+		deadlineUnix := timeutil.TimeStamp(form.Deadline.Unix())
-		deadlineUnix = timeutil.TimeStamp(form.Deadline.Unix())
+		if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil {
-	}
+			ctx.Error(500, "UpdateIssueDeadline", err)
-
+			return
-	if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil {
+		}
-		ctx.Error(500, "UpdateIssueDeadline", err)
+		issue.DeadlineUnix = deadlineUnix
-		return
 	}
 
 	// Add/delete assignees

routers/api/v1/repo/pull.go

@@ -392,14 +392,13 @@ func EditPullRequest(ctx *context.APIContext, form api.EditPullRequestOption) {
 	}
 
 	// Update Deadline
-	var deadlineUnix timeutil.TimeStamp
+	if form.Deadline != nil {
-	if form.Deadline != nil && !form.Deadline.IsZero() {
+		deadlineUnix := timeutil.TimeStamp(form.Deadline.Unix())
-		deadlineUnix = timeutil.TimeStamp(form.Deadline.Unix())
+		if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil {
-	}
+			ctx.Error(500, "UpdateIssueDeadline", err)
-
+			return
-	if err := models.UpdateIssueDeadline(issue, deadlineUnix, ctx.User); err != nil {
+		}
-		ctx.Error(500, "UpdateIssueDeadline", err)
+		issue.DeadlineUnix = deadlineUnix
-		return
 	}
 
 	// Add/delete assignees