Fix milestone links (#12405)

The milestone pages links should direct to the milestone pages

Fix #10215

Signed-off-by: Andrew Thornton <art27@cantab.net>

templates/repo/issue/list.tmpl

@@ -242,7 +242,7 @@
 						{{end}}
 
 						{{if .Milestone}}
-							<a class="milestone" href="{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{.Milestone.ID}}&assignee={{$.AssigneeID}}">
+							<a class="milestone" href="{{$.RepoLink}}/milestone/{{.Milestone.ID}}">
 								{{svg "octicon-milestone" 16}} {{.Milestone.Name}}
 							</a>
 						{{end}}

templates/user/dashboard/issues.tmpl

@@ -142,7 +142,7 @@
 									{{$.i18n.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName|Escape) | Safe}}
 								{{end}}
 								{{if .Milestone}}
-									<a class="milestone" href="{{AppSubUrl}}/{{.Repo.Owner.Name}}/{{.Repo.Name}}{{$.Link}}?q={{$.Keyword}}&type={{$.ViewType}}&state={{$.State}}&labels={{$.SelectLabels}}&milestone={{.Milestone.ID}}&assignee={{$.AssigneeID}}">
+									<a class="milestone" href="{{AppSubUrl}}/{{.Repo.Owner.Name}}/{{.Repo.Name}}/milestone/{{.Milestone.ID}}">
 										{{svg "octicon-milestone" 16}} {{.Milestone.Name}}
 									</a>
 								{{end}}