[Fix] Release attachment should use DownloadURL() not Name (#9529)

* Handle if two or more attachments have the same name
* previously only the first could be downloaded - now each is downloadable
* dos also take care of  #6506 (fix was: #6512)
* use func DownloadURL() at issue attatchments too

routers/repo/repo.go

@@ -426,7 +426,7 @@ func RedirectDownload(ctx *context.Context) {
 			return
 		}
 		if att != nil {
-			ctx.Redirect(setting.AppSubURL + "/attachments/" + att.UUID)
+			ctx.Redirect(att.DownloadURL())
 			return
 		}
 	}

templates/repo/issue/view_content/attachments.tmpl

@@ -1,9 +1,9 @@
 {{range .Attachments}}
-  <a target="_blank" rel="noopener noreferrer" href="{{AppSubUrl}}/attachments/{{.UUID}}">
+  <a target="_blank" rel="noopener noreferrer" href="{{.DownloadURL}}">
     {{if FilenameIsImage .Name}}
-      <img class="ui image" src="{{AppSubUrl}}/attachments/{{.UUID}}" title='{{$.ctx.i18n.Tr "repo.issues.attachment.open_tab" .Name}}'>
+      <img class="ui image" src="{{.DownloadURL}}" title='{{$.ctx.i18n.Tr "repo.issues.attachment.open_tab" .Name}}'>
     {{else}}
       <span class="ui image octicon octicon-desktop-download" title='{{$.ctx.i18n.Tr "repo.issues.attachment.download" .Name}}'></span>
     {{end}}
   </a>
-{{end}}
+{{end}}

templates/repo/release/list.tmpl

@@ -82,11 +82,11 @@
 									</li>
 									{{end}}
 									{{if .Attachments}}
-										{{range $attachment := .Attachments}}
+										{{range .Attachments}}
 										<li>
-											<a target="_blank" rel="noopener noreferrer" href="{{$.RepoLink}}/releases/download/{{$release.TagName | PathEscape}}/{{$attachment.Name | PathEscape}}">
+											<a target="_blank" rel="noopener noreferrer" href="{{.DownloadURL}}">
-												<strong><span class="ui image octicon octicon-package" title='{{$attachment.Name}}'></span> {{$attachment.Name}}</strong>
+												<strong><span class="ui image octicon octicon-package" title='{{.Name}}'></span> {{.Name}}</strong>
-												<span class="ui text grey right">{{$attachment.Size | FileSize}}</span>
+												<span class="ui text grey right">{{.Size | FileSize}}</span>
 											</a>
 										</li>
 										{{end}}