Add verify changed less-file step to Makefile (#1861)

.drone.yml

@@ -20,6 +20,7 @@ pipeline:
       - make generate
       - make vet
       - make lint
+      - make stylesheets-check
       - make misspell-check
       - make test-vendor
       - make build

Makefile

@@ -15,7 +15,6 @@ endif
 
 BINDATA := modules/{options,public,templates}/bindata.go
 STYLESHEETS := $(wildcard public/less/index.less public/less/_*.less)
-JAVASCRIPTS :=
 DOCKER_TAG := gitea/gitea:latest
 GOFILES := $(shell find . -name "*.go" -type f ! -path "./vendor/*" ! -path "*/bindata.go")
 GOFMT ?= gofmt -s
@@ -261,12 +260,24 @@ javascripts: public/js/index.js
 public/js/index.js: $(JAVASCRIPTS)
 	cat $< >| $@
 
+.PHONY: stylesheets-check
+stylesheets-check: stylesheets
+	@diff=$$(git diff public/css/index.css); \
+	if [ -n "$$diff" ]; then \
+		echo "Please run 'make less' and commit the result:"; \
+		echo "$${diff}"; \
+		exit 1; \
+	fi;
+
 .PHONY: stylesheets
 stylesheets: public/css/index.css
 
 .IGNORE: public/css/index.css
 public/css/index.css: $(STYLESHEETS)
-	lessc $< $@
+	@which lessc > /dev/null; if [ $$? -ne 0 ]; then \
+		go get -u github.com/kib357/less-go/lessc; \
+	fi
+	lessc -i $< -o $@
 
 .PHONY: swagger-ui
 swagger-ui:
@@ -276,9 +287,6 @@ swagger-ui:
 	rm -Rf /tmp/swagger-ui
 	$(SED_INPLACE) "s;http://petstore.swagger.io/v2/swagger.json;../../swagger.v1.json;g" public/assets/swagger-ui/index.html
 
-.PHONY: assets
-assets: javascripts stylesheets
-
 .PHONY: update-translations
 update-translations:
 	mkdir -p ./translations

public/css/index.css

@@ -430,28 +430,28 @@ footer .ui.language .menu {
 }
 @media only screen and (max-width: 1200px) {
   .ui.menu.new-menu {
-      overflow-x: auto !important;
+    overflow-x: auto !important;
-      justify-content: left !important;
+    justify-content: left !important;
-      padding-bottom: 5px;
+    padding-bottom: 5px;
   }
   .ui.menu.new-menu::-webkit-scrollbar {
-      height: 8px;
+    height: 8px;
-      display: none;
+    display: none;
   }
   .ui.menu.new-menu:hover::-webkit-scrollbar {
     display: block;
   }
   .ui.menu.new-menu::-webkit-scrollbar-track {
-    background: rgba(0,0,0,0.01);
+    background: rgba(0, 0, 0, 0.01);
   }
   .ui.menu.new-menu::-webkit-scrollbar-thumb {
-      background:rgba(0,0,0,0.2);
+    background: rgba(0, 0, 0, 0.2);
   }
   .ui.menu.new-menu:after {
     position: absolute;
     margin-top: -15px;
     display: block;
-    background-image: linear-gradient(to right, rgba(255, 255, 255, 0), rgba(255, 255, 255, 1) 100%);
+    background-image: linear-gradient(to right, rgba(255, 255, 255, 0), #ffffff 100%);
     content: ' ';
     right: 0;
     height: 53px;