Return 404 when user is not found on avatar (#21476)

- Instead of returning a 500 Internal Server when the user wasn't found,
return 404 Not found
tokarchuk/v1.18
Gusted 2 years ago committed by GitHub
parent 11d3677818
commit 5d3dbffa15
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      routers/web/user/avatar.go

@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
if strings.ToLower(userName) != "ghost" { if strings.ToLower(userName) != "ghost" {
var err error var err error
if user, err = user_model.GetUserByName(ctx, userName); err != nil { if user, err = user_model.GetUserByName(ctx, userName); err != nil {
if user_model.IsErrUserNotExist(err) {
ctx.NotFound("GetUserByName", err)
return
}
ctx.ServerError("Invalid user: "+userName, err) ctx.ServerError("Invalid user: "+userName, err)
return return
} }

Loading…
Cancel
Save