Integration tests for issues API (#2059)

tokarchuk/v1.17
Ethan Koenig 7 years ago committed by Lunny Xiao
parent 4c0e567062
commit 735676267e
  1. 65
      integrations/api_issue_test.go
  2. 28
      routers/api/v1/repo/issue.go

@ -0,0 +1,65 @@
// Copyright 2017 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package integrations
import (
"net/http"
"testing"
"code.gitea.io/gitea/models"
api "code.gitea.io/sdk/gitea"
"fmt"
"github.com/stretchr/testify/assert"
)
func TestAPIListIssues(t *testing.T) {
prepareTestEnv(t)
repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
session := loginUser(t, owner.Name)
req := NewRequestf(t, "GET", "/api/v1/repos/%s/%s/issues?state=all",
owner.Name, repo.Name)
resp := session.MakeRequest(t, req)
assert.EqualValues(t, http.StatusOK, resp.HeaderCode)
var apiIssues []*api.Issue
DecodeJSON(t, resp, &apiIssues)
assert.Len(t, apiIssues, models.GetCount(t, &models.Issue{RepoID: repo.ID}))
for _, apiIssue := range apiIssues {
models.AssertExistsAndLoadBean(t, &models.Issue{ID: apiIssue.ID, RepoID: repo.ID})
}
}
func TestAPICreateIssue(t *testing.T) {
prepareTestEnv(t)
const body, title = "apiTestBody", "apiTestTitle"
repo := models.AssertExistsAndLoadBean(t, &models.Repository{ID: 1}).(*models.Repository)
owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User)
session := loginUser(t, owner.Name)
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues?state=all", owner.Name, repo.Name)
req := NewRequestWithJSON(t, "POST", urlStr, &api.CreateIssueOption{
Body: body,
Title: title,
Assignee: owner.Name,
})
resp := session.MakeRequest(t, req)
assert.EqualValues(t, http.StatusCreated, resp.HeaderCode)
var apiIssue api.Issue
DecodeJSON(t, resp, &apiIssue)
assert.Equal(t, apiIssue.Body, body)
assert.Equal(t, apiIssue.Title, title)
models.AssertExistsAndLoadBean(t, &models.Issue{
RepoID: repo.ID,
AssigneeID: owner.ID,
Content: body,
Title: title,
})
}

@ -18,27 +18,25 @@ import (
// ListIssues list the issues of a repository // ListIssues list the issues of a repository
func ListIssues(ctx *context.APIContext) { func ListIssues(ctx *context.APIContext) {
isClosed := ctx.Query("state") == "closed" var isClosed util.OptionalBool
issueOpts := models.IssuesOptions{ switch ctx.Query("state") {
RepoID: ctx.Repo.Repository.ID, case "closed":
Page: ctx.QueryInt("page"), isClosed = util.OptionalBoolTrue
IsClosed: util.OptionalBoolOf(isClosed), case "all":
isClosed = util.OptionalBoolNone
default:
isClosed = util.OptionalBoolFalse
} }
issues, err := models.Issues(&issueOpts) issues, err := models.Issues(&models.IssuesOptions{
if err != nil { RepoID: ctx.Repo.Repository.ID,
ctx.Error(500, "Issues", err) Page: ctx.QueryInt("page"),
return IsClosed: isClosed,
} })
if ctx.Query("state") == "all" {
issueOpts.IsClosed = util.OptionalBoolOf(!isClosed)
tempIssues, err := models.Issues(&issueOpts)
if err != nil { if err != nil {
ctx.Error(500, "Issues", err) ctx.Error(500, "Issues", err)
return return
} }
issues = append(issues, tempIssues...)
}
err = models.IssueList(issues).LoadAttributes() err = models.IssueList(issues).LoadAttributes()
if err != nil { if err != nil {

Loading…
Cancel
Save